harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: svn commit: r646259 - in /harmony/enhanced/classlib/trunk/modules/luni/src/test/api/common/org/apache/harmony/luni/tests/java/util: AbstractMapTest.java AbstractSequentialListTest.java CalendarTest.java
Date Thu, 10 Apr 2008 08:37:32 GMT
Thanks.  Just shout if you want some help.

Regards,
Tim

Sean Qiu wrote:
> I am so sorry about it.
> 
> I think it is because i pay less attention to the test.
> I will pay more attention to it from now on.
> 
> I will supply the patch ASAP.
> Sorry again. :(
> 
> 2008/4/10, Tony Wu <wuyuehao@gmail.com>:
>> Yes, agree. Thanks Tim.
>>
>> Sean,
>>
>> would you please submit another patch for HARMONY-5699 with tidy-up...
>>
>> On 4/9/08, Tim Ellison <t.p.ellison@gmail.com> wrote:
>>> Tony,
>>>
>>> I think these tests need a bit of tidy-up,
>>>
>>> - lots of assertEquals true|false|null  where it would be more natural and
>>> readable to use assertTrue, assertNull etc.
>>>
>>> Just write:
>>>  assertEquals("Should equal to be empty.", true, map.isEmpty());
>>> as
>>>  assertTrue(map.isEmpty());
>>>
>>> - contains unhelpful printing to stdout "System.out.println(map);"
>>>
>>> Regards,
>>> Tim


Mime
View raw message