harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer" <ndbe...@apache.org>
Subject Re: [classlib][luni]Date.getTimezoneOffset return wrong value
Date Wed, 30 Apr 2008 00:14:39 GMT
On Tue, Apr 29, 2008 at 7:49 AM, Tim Ellison <t.p.ellison@gmail.com> wrote:

> Nathan Beyer wrote:
>
> > Yes, this seems like it's a larger problem. We need to follow suit with
> > the
> > other VM vendors and begin utilizing the Olson zoneinfo with regular
> > updates
> > and eventually and updater tool.
> >
>
> Why not get the timezone info via ICU since it is a dependency anyway?
> They in turn get it from CLDR/Olson and have the tools for updating to later
> data, including a tool to apply changes that don't take effect until some
> point in the future!


That sounds good too me. Let someone else do the hard work.

-Nathan


>
>
> [1] http://www.icu-project.org/userguide/dateTimezone.html
>
> Regards,
> Tim
>
>
>  On Fri, Apr 25, 2008 at 1:38 PM, Tim Ellison <t.p.ellison@gmail.com<https://mail.google.com/mail?view=cm&tf=0&to=t.p.ellison@gmail.com>>
> > wrote:
> >
> >  Jim Yu wrote:
> > >
> > >  I looked at this issue from the JIRA[1]. The testcase works fine on
> > > > RI but
> > > > fails on Harmony in the second assert statement.
> > > > I found that the returned TimeZone instance from
> > > > TimeZone.getTimeZone("America/Toronto") on Harmony was "GMT" other
> > > > than
> > > > "America/Toronto". That's why the second assert statement fails on
> > > > Harmony.
> > > > I attached a patch to the JIRA[1], which will solve
> > > > this issue. Anybody to verify it? If no objection, I will ask a
> > > > committer
> > > > to
> > > > apply it: )
> > > >
> > > >  I ran a simple comparison of Sun's 1.6b03 time zone IDs with
> > > Harmony's, and
> > > there are quite a few in the same category.
> > >
> > > A diff of the sorted output from TimeZone.getAvailableIDs() is given
> > > below.
> > >
> > > Regards,
> > > Tim
> > >
> > > --
> > >
> > > *** hy.txt      Fri Apr 25 17:08:28 2008
> > > --- ri.txt      Fri Apr 25 19:34:34 2008
> > > ***************
> > > *** 7,25 ****
> > > --- 7,30 ----
> > >  Africa/Accra
> > >  Africa/Addis_Ababa
> > >  Africa/Algiers
> > > + Africa/Asmara
> > >  Africa/Asmera
> > > + Africa/Bamako
> > >  Africa/Bangui
> > >  Africa/Banjul
> > >  Africa/Bissau
> > >  Africa/Blantyre
> > > + Africa/Brazzaville
> > >  Africa/Bujumbura
> > >  Africa/Cairo
> > >  Africa/Casablanca
> > > + Africa/Ceuta
> > >  Africa/Conakry
> > >  Africa/Dakar
> > >  Africa/Dar_es_Salaam
> > >  Africa/Djibouti
> > >  Africa/Douala
> > > + Africa/El_Aaiun
> > >  Africa/Freetown
> > >  Africa/Gaborone
> > >  Africa/Harare
> > > ***************
> > > *** 55,133 ****
> > > --- 60,221 ----
> > >  America/Anchorage
> > >  America/Anguilla
> > >  America/Antigua
> > > + America/Araguaina
> > > + America/Argentina/Buenos_Aires
> > > + America/Argentina/Catamarca
> > > + America/Argentina/ComodRivadavia
> > > + America/Argentina/Cordoba
> > > + America/Argentina/Jujuy
> > > + America/Argentina/La_Rioja
> > > + America/Argentina/Mendoza
> > > + America/Argentina/Rio_Gallegos
> > > + America/Argentina/San_Juan
> > > + America/Argentina/Tucuman
> > > + America/Argentina/Ushuaia
> > >  America/Aruba
> > >  America/Asuncion
> > > + America/Atikokan
> > > + America/Atka
> > > + America/Bahia
> > >  America/Barbados
> > > + America/Belem
> > >  America/Belize
> > > + America/Blanc-Sablon
> > > + America/Boa_Vista
> > >  America/Bogota
> > > + America/Boise
> > >  America/Buenos_Aires
> > > + America/Cambridge_Bay
> > > + America/Campo_Grande
> > > + America/Cancun
> > >  America/Caracas
> > > + America/Catamarca
> > >  America/Cayenne
> > >  America/Cayman
> > >  America/Chicago
> > > + America/Chihuahua
> > > + America/Coral_Harbour
> > > + America/Cordoba
> > >  America/Costa_Rica
> > >  America/Cuiaba
> > >  America/Curacao
> > > + America/Danmarkshavn
> > > + America/Dawson
> > >  America/Dawson_Creek
> > >  America/Denver
> > > + America/Detroit
> > >  America/Dominica
> > >  America/Edmonton
> > > + America/Eirunepe
> > >  America/El_Salvador
> > > + America/Ensenada
> > > + America/Fort_Wayne
> > >  America/Fortaleza
> > > + America/Glace_Bay
> > >  America/Godthab
> > > + America/Goose_Bay
> > >  America/Grand_Turk
> > >  America/Grenada
> > >  America/Guadeloupe
> > > + America/Guatemala
> > >  America/Guayaquil
> > >  America/Guyana
> > >  America/Halifax
> > >  America/Havana
> > > + America/Hermosillo
> > > + America/Indiana/Indianapolis
> > > + America/Indiana/Knox
> > > + America/Indiana/Marengo
> > > + America/Indiana/Petersburg
> > > + America/Indiana/Tell_City
> > > + America/Indiana/Vevay
> > > + America/Indiana/Vincennes
> > > + America/Indiana/Winamac
> > >  America/Indianapolis
> > > + America/Inuvik
> > > + America/Iqaluit
> > >  America/Jamaica
> > > + America/Jujuy
> > > + America/Juneau
> > > + America/Kentucky/Louisville
> > > + America/Kentucky/Monticello
> > > + America/Knox_IN
> > >  America/La_Paz
> > >  America/Lima
> > >  America/Los_Angeles
> > > + America/Louisville
> > > + America/Maceio
> > >  America/Managua
> > >  America/Manaus
> > >  America/Martinique
> > >  America/Mazatlan
> > > + America/Mendoza
> > > + America/Menominee
> > > + America/Merida
> > >  America/Mexico_City
> > >  America/Miquelon
> > > + America/Moncton
> > > + America/Monterrey
> > >  America/Montevideo
> > >  America/Montreal
> > >  America/Montserrat
> > >  America/Nassau
> > >  America/New_York
> > > + America/Nipigon
> > > + America/Nome
> > >  America/Noronha
> > > + America/North_Dakota/Center
> > > + America/North_Dakota/New_Salem
> > >  America/Panama
> > > + America/Pangnirtung
> > >  America/Paramaribo
> > >  America/Phoenix
> > >  America/Port-au-Prince
> > >  America/Port_of_Spain
> > >  America/Porto_Acre
> > > + America/Porto_Velho
> > >  America/Puerto_Rico
> > > + America/Rainy_River
> > > + America/Rankin_Inlet
> > > + America/Recife
> > >  America/Regina
> > > + America/Resolute
> > >  America/Rio_Branco
> > > + America/Rosario
> > >  America/Santiago
> > >  America/Santo_Domingo
> > >  America/Sao_Paulo
> > >  America/Scoresbysund
> > > + America/Shiprock
> > >  America/St_Johns
> > >  America/St_Kitts
> > >  America/St_Lucia
> > >  America/St_Thomas
> > >  America/St_Vincent
> > > + America/Swift_Current
> > >  America/Tegucigalpa
> > >  America/Thule
> > > + America/Thunder_Bay
> > >  America/Tijuana
> > > + America/Toronto
> > >  America/Tortola
> > >  America/Vancouver
> > > + America/Virgin
> > > + America/Whitehorse
> > >  America/Winnipeg
> > > + America/Yakutat
> > > + America/Yellowknife
> > >  Antarctica/Casey
> > > + Antarctica/Davis
> > >  Antarctica/DumontDUrville
> > >  Antarctica/Mawson
> > >  Antarctica/McMurdo
> > >  Antarctica/Palmer
> > > + Antarctica/Rothera
> > > + Antarctica/South_Pole
> > > + Antarctica/Syowa
> > > + Antarctica/Vostok
> > > + Arctic/Longyearbyen
> > >  Asia/Aden
> > >  Asia/Almaty
> > >  Asia/Amman
> > > ***************
> > > *** 144,179 ****
> > > --- 232,288 ----
> > >  Asia/Bishkek
> > >  Asia/Brunei
> > >  Asia/Calcutta
> > > + Asia/Choibalsan
> > > + Asia/Chongqing
> > > + Asia/Chungking
> > >  Asia/Colombo
> > >  Asia/Dacca
> > >  Asia/Damascus
> > >  Asia/Dhaka
> > > + Asia/Dili
> > >  Asia/Dubai
> > >  Asia/Dushanbe
> > > + Asia/Gaza
> > > + Asia/Harbin
> > >  Asia/Hong_Kong
> > > + Asia/Hovd
> > >  Asia/Irkutsk
> > > + Asia/Istanbul
> > >  Asia/Jakarta
> > >  Asia/Jayapura
> > >  Asia/Jerusalem
> > >  Asia/Kabul
> > >  Asia/Kamchatka
> > >  Asia/Karachi
> > > + Asia/Kashgar
> > >  Asia/Katmandu
> > >  Asia/Krasnoyarsk
> > >  Asia/Kuala_Lumpur
> > > + Asia/Kuching
> > >  Asia/Kuwait
> > >  Asia/Macao
> > > + Asia/Macau
> > >  Asia/Magadan
> > > + Asia/Makassar
> > >  Asia/Manila
> > >  Asia/Muscat
> > >  Asia/Nicosia
> > >  Asia/Novosibirsk
> > > + Asia/Omsk
> > > + Asia/Oral
> > >  Asia/Phnom_Penh
> > > + Asia/Pontianak
> > >  Asia/Pyongyang
> > >  Asia/Qatar
> > > + Asia/Qyzylorda
> > >  Asia/Rangoon
> > >  Asia/Riyadh
> > > + Asia/Riyadh87
> > > + Asia/Riyadh88
> > > + Asia/Riyadh89
> > >  Asia/Saigon
> > > + Asia/Sakhalin
> > > + Asia/Samarkand
> > >  Asia/Seoul
> > >  Asia/Shanghai
> > >  Asia/Singapore
> > > ***************
> > > *** 181,192 ****
> > > --- 290,303 ----
> > >  Asia/Tashkent
> > >  Asia/Tbilisi
> > >  Asia/Tehran
> > > + Asia/Tel_Aviv
> > >  Asia/Thimbu
> > >  Asia/Thimphu
> > >  Asia/Tokyo
> > >  Asia/Ujung_Pandang
> > >  Asia/Ulaanbaatar
> > >  Asia/Ulan_Bator
> > > + Asia/Urumqi
> > >  Asia/Vientiane
> > >  Asia/Vladivostok
> > >  Asia/Yakutsk
> > > ***************
> > > *** 197,230 ****
> > > --- 308,416 ----
> > >  Atlantic/Canary
> > >  Atlantic/Cape_Verde
> > >  Atlantic/Faeroe
> > > + Atlantic/Faroe
> > >  Atlantic/Jan_Mayen
> > > + Atlantic/Madeira
> > >  Atlantic/Reykjavik
> > >  Atlantic/South_Georgia
> > >  Atlantic/St_Helena
> > >  Atlantic/Stanley
> > > + Australia/ACT
> > >  Australia/Adelaide
> > >  Australia/Brisbane
> > >  Australia/Broken_Hill
> > > + Australia/Canberra
> > > + Australia/Currie
> > >  Australia/Darwin
> > > + Australia/Eucla
> > >  Australia/Hobart
> > > + Australia/LHI
> > > + Australia/Lindeman
> > >  Australia/Lord_Howe
> > > + Australia/Melbourne
> > > + Australia/NSW
> > > + Australia/North
> > >  Australia/Perth
> > > + Australia/Queensland
> > > + Australia/South
> > >  Australia/Sydney
> > > + Australia/Tasmania
> > > + Australia/Victoria
> > > + Australia/West
> > > + Australia/Yancowinna
> > >  BET
> > >  BST
> > > + Brazil/Acre
> > > + Brazil/DeNoronha
> > > + Brazil/East
> > > + Brazil/West
> > >  CAT
> > > + CET
> > >  CNT
> > >  CST
> > > + CST6CDT
> > >  CTT
> > > + Canada/Atlantic
> > > + Canada/Central
> > > + Canada/East-Saskatchewan
> > > + Canada/Eastern
> > > + Canada/Mountain
> > > + Canada/Newfoundland
> > > + Canada/Pacific
> > > + Canada/Saskatchewan
> > > + Canada/Yukon
> > > + Chile/Continental
> > > + Chile/EasterIsland
> > > + Cuba
> > >  EAT
> > >  ECT
> > >  EET
> > >  EST
> > > + EST5EDT
> > > + Egypt
> > > + Eire
> > > + Etc/GMT
> > > + Etc/GMT+0
> > > + Etc/GMT+1
> > > + Etc/GMT+10
> > > + Etc/GMT+11
> > > + Etc/GMT+12
> > > + Etc/GMT+2
> > > + Etc/GMT+3
> > > + Etc/GMT+4
> > > + Etc/GMT+5
> > > + Etc/GMT+6
> > > + Etc/GMT+7
> > > + Etc/GMT+8
> > > + Etc/GMT+9
> > > + Etc/GMT-0
> > > + Etc/GMT-1
> > > + Etc/GMT-10
> > > + Etc/GMT-11
> > > + Etc/GMT-12
> > > + Etc/GMT-13
> > > + Etc/GMT-14
> > > + Etc/GMT-2
> > > + Etc/GMT-3
> > > + Etc/GMT-4
> > > + Etc/GMT-5
> > > + Etc/GMT-6
> > > + Etc/GMT-7
> > > + Etc/GMT-8
> > > + Etc/GMT-9
> > > + Etc/GMT0
> > > + Etc/Greenwich
> > > + Etc/UCT
> > > + Etc/UTC
> > > + Etc/Universal
> > > + Etc/Zulu
> > >  Europe/Amsterdam
> > >  Europe/Andorra
> > >  Europe/Athens
> > > + Europe/Belfast
> > >  Europe/Belgrade
> > >  Europe/Berlin
> > > + Europe/Bratislava
> > >  Europe/Brussels
> > >  Europe/Bucharest
> > >  Europe/Budapest
> > > ***************
> > > *** 232,269 ****
> > > --- 418,477 ----
> > >  Europe/Copenhagen
> > >  Europe/Dublin
> > >  Europe/Gibraltar
> > > + Europe/Guernsey
> > >  Europe/Helsinki
> > > + Europe/Isle_of_Man
> > >  Europe/Istanbul
> > > + Europe/Jersey
> > >  Europe/Kaliningrad
> > >  Europe/Kiev
> > >  Europe/Lisbon
> > > + Europe/Ljubljana
> > >  Europe/London
> > >  Europe/Luxembourg
> > >  Europe/Madrid
> > >  Europe/Malta
> > > + Europe/Mariehamn
> > >  Europe/Minsk
> > >  Europe/Monaco
> > >  Europe/Moscow
> > > + Europe/Nicosia
> > >  Europe/Oslo
> > >  Europe/Paris
> > > + Europe/Podgorica
> > >  Europe/Prague
> > >  Europe/Riga
> > >  Europe/Rome
> > >  Europe/Samara
> > > + Europe/San_Marino
> > > + Europe/Sarajevo
> > >  Europe/Simferopol
> > > + Europe/Skopje
> > >  Europe/Sofia
> > >  Europe/Stockholm
> > >  Europe/Tallinn
> > >  Europe/Tirane
> > > + Europe/Tiraspol
> > > + Europe/Uzhgorod
> > >  Europe/Vaduz
> > > + Europe/Vatican
> > >  Europe/Vienna
> > >  Europe/Vilnius
> > > + Europe/Volgograd
> > >  Europe/Warsaw
> > > + Europe/Zagreb
> > > + Europe/Zaporozhye
> > >  Europe/Zurich
> > > + GB
> > > + GB-Eire
> > >  GMT
> > > + GMT0
> > > + Greenwich
> > >  HST
> > > + Hongkong
> > >  IET
> > >  IST
> > > + Iceland
> > >  Indian/Antananarivo
> > >  Indian/Chagos
> > >  Indian/Christmas
> > > ***************
> > > *** 275,290 ****
> > > --- 483,516 ----
> > >  Indian/Mauritius
> > >  Indian/Mayotte
> > >  Indian/Reunion
> > > + Iran
> > > + Israel
> > >  JST
> > > + Jamaica
> > > + Japan
> > > + Kwajalein
> > > + Libya
> > >  MET
> > >  MIT
> > >  MST
> > > + MST7MDT
> > > + Mexico/BajaNorte
> > > + Mexico/BajaSur
> > > + Mexico/General
> > > + Mideast/Riyadh87
> > > + Mideast/Riyadh88
> > > + Mideast/Riyadh89
> > >  NET
> > >  NST
> > > + NZ
> > > + NZ-CHAT
> > > + Navajo
> > >  PLT
> > >  PNT
> > > + PRC
> > >  PRT
> > >  PST
> > > + PST8PDT
> > >  Pacific/Apia
> > >  Pacific/Auckland
> > >  Pacific/Chatham
> > > ***************
> > > *** 299,308 ****
> > > --- 525,537 ----
> > >  Pacific/Guadalcanal
> > >  Pacific/Guam
> > >  Pacific/Honolulu
> > > + Pacific/Johnston
> > >  Pacific/Kiritimati
> > >  Pacific/Kosrae
> > > + Pacific/Kwajalein
> > >  Pacific/Majuro
> > >  Pacific/Marquesas
> > > + Pacific/Midway
> > >  Pacific/Nauru
> > >  Pacific/Niue
> > >  Pacific/Norfolk
> > > ***************
> > > *** 314,326 ****
> > > --- 543,592 ----
> > >  Pacific/Port_Moresby
> > >  Pacific/Rarotonga
> > >  Pacific/Saipan
> > > + Pacific/Samoa
> > >  Pacific/Tahiti
> > >  Pacific/Tarawa
> > >  Pacific/Tongatapu
> > >  Pacific/Truk
> > >  Pacific/Wake
> > >  Pacific/Wallis
> > > + Pacific/Yap
> > > + Poland
> > > + Portugal
> > > + ROK
> > >  SST
> > > + Singapore
> > > + SystemV/AST4
> > > + SystemV/AST4ADT
> > > + SystemV/CST6
> > > + SystemV/CST6CDT
> > > + SystemV/EST5
> > > + SystemV/EST5EDT
> > > + SystemV/HST10
> > > + SystemV/MST7
> > > + SystemV/MST7MDT
> > > + SystemV/PST8
> > > + SystemV/PST8PDT
> > > + SystemV/YST9
> > > + SystemV/YST9YDT
> > > + Turkey
> > > + UCT
> > > + US/Alaska
> > > + US/Aleutian
> > > + US/Arizona
> > > + US/Central
> > > + US/East-Indiana
> > > + US/Eastern
> > > + US/Hawaii
> > > + US/Indiana-Starke
> > > + US/Michigan
> > > + US/Mountain
> > > + US/Pacific
> > > + US/Pacific-New
> > > + US/Samoa
> > >  UTC
> > > + Universal
> > >  VST
> > > + W-SU
> > >  WET
> > > + Zulu
> > >
> > >
> >

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message