harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer" <ndbe...@apache.org>
Subject Re: [classlib][luni][performance] Improvements in Collections
Date Fri, 18 Apr 2008 19:33:10 GMT
That patch wasn't applied 'as-is', so I wouldn't agree to that. However, I
would agree to making WeakHashMap and IdendityHashMap consistent, if not
just use the same code, with HashMap.

-Nathan

On Fri, Apr 18, 2008 at 2:26 PM, Sergey Salishev <
sergey.i.salishev@gmail.com> wrote:

> Nathan,
>
> Do you have any problems with applying the
> https://issues.apache.org/jira/browse/HARMONY-4064 patch to the
> WeakHashMap?
>
> Thanks,
> Sergey.
>
>
> On Fri, Apr 18, 2008 at 11:21 PM, Aleksey Shipilev <
> aleksey.shipilev@gmail.com<https://mail.google.com/mail?view=cm&tf=0&to=aleksey.shipilev@gmail.com>>
> wrote:
>
> > Ok, let's start over. Current implementation of *HM does not guarantee
> > the storage size is 2^k. On the other hand such the requirement is the
> > _prerequisite_ for performance optimization done in the patch. Thus
> > the rounding code is the essential part of the patch and can't be
> > removed. Removal of this code will lead to performance degradations.
> > We can inline this method into computeCapacity for convenience reasons
> > (I'm sorry now I hadn't done that already).
> >
> > Is there any problem with my arguments?
> >
> > Thanks,
> > Aleksey.
> >
> > On Fri, Apr 18, 2008 at 11:14 PM, Nathan Beyer <ndbeyer@apache.org<https://mail.google.com/mail?view=cm&tf=0&to=ndbeyer@apache.org>>
> wrote:
> > >  I think the capacity calculation should be removed from the patch.
> It's
> > NOT
> > >  the performance boost, correct?
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message