Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 67841 invoked from network); 7 Mar 2008 15:59:36 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 7 Mar 2008 15:59:36 -0000 Received: (qmail 58865 invoked by uid 500); 7 Mar 2008 15:59:31 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 58846 invoked by uid 500); 7 Mar 2008 15:59:31 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 58837 invoked by uid 99); 7 Mar 2008 15:59:31 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Mar 2008 07:59:31 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of alexei.fedotov@gmail.com designates 64.233.184.229 as permitted sender) Received: from [64.233.184.229] (HELO wr-out-0506.google.com) (64.233.184.229) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Mar 2008 15:58:55 +0000 Received: by wr-out-0506.google.com with SMTP id 57so181585wri.12 for ; Fri, 07 Mar 2008 07:59:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=cDqnflcd0gVfUNkJ4MA5R5P7t5aIAJBC5wYxSGsO7A4=; b=hpZy8CkteWQtWpB86TwC9WodVpFadfYhHzyN/Rs2cHOB/2I6qX3ySSBa2YGuT3ureFbCcRyPV6vksukElQImzU4kJvHO5AaaZg/4l2JC5Q3rmiGUGbXRSrOwdCyXie3GtCNyr1oZ8uumzWdVMuRoaZQsqguhs3Z3TN43z4Z/WRA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=NVU18uPp8Y/G/tR1Tiq1O+K1qlK8St9GmOx0ghtJ8zf24FKbeUN5GBVdy+FUOIEp7S/vU539qSrFbvhjzrZM8PJoC4xU5LKqKrJJM5k0BnL9z0HiicHb43TY3PDGS3EQQ7n14/Hxfvw5yOM0/Kl9eWYGpT21gP7qy4AWkzIofNw= Received: by 10.141.171.6 with SMTP id y6mr618426rvo.174.1204905544148; Fri, 07 Mar 2008 07:59:04 -0800 (PST) Received: by 10.67.20.16 with HTTP; Fri, 7 Mar 2008 07:59:04 -0800 (PST) Message-ID: Date: Fri, 7 Mar 2008 18:59:04 +0300 From: "Alexei Fedotov" To: dev@harmony.apache.org Subject: Re: svn commit: r634547 [2/2] - in /harmony/enhanced/drlvm/trunk/vm: em/src/ include/open/ interpreter/src/ jitrino/src/codegenerator/ia32/ jitrino/src/codegenerator/ipf/ jitrino/src/jet/ jitrino/src/shared/ jitrino/src/vm/ vmcore/build/ vmcore/src/c In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: X-Virus-Checked: Checked by ClamAV on apache.org Hello, I vote for not using Boolean at all. jboolean is a part of the standard we are implementing [1] while Boolean is not. The same applies to JNI_TRUE/JNI_FALSE macros in favour of TRUE/FALSE. [1] http://java.sun.com/docs/books/jni/html/types.html On Fri, Mar 7, 2008 at 6:49 PM, Mikhail Fursov wrote: > Alexey, > there is a problem with this commit. > Some of methods that returns Boolean (that is 'unsigned') are described as > 'bool' in vm_interface.h > It's not the same and causes problems. For example I found that H2092 fails [...] -- With best regards, Alexei