Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of alexei.zakharov@gmail.com
 designates 209.85.146.180 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=dD6cDVqp0Flr4pPeZcB/21FUktc2llSttSmmIxghhf6GrSeBZefUr65ZoeGoeuQiBXjV4Mb0aK4SzBc2vVq2JbeKO2MwEkOZJu8ufrhUBXHRQFPj6NRmKVaEM0Nf21VONy6Yv8Qh4Ugymagpqo2zJLrKZUYvlMg9rf7IyYZQkMU=
Message-ID: <2c9597b90803280802s16dbd1e6qb5863be6de583db8@mail.gmail.com>
Date: Fri, 28 Mar 2008 18:02:33 +0300
From: "Alexei Zakharov" <alexei.zakharov@gmail.com>
To: dev@harmony.apache.org
Subject: Re: [classlib][archive] Non-UTF8 character in manifest during
 confluence startup (HARMONY-5662)
In-Reply-To: <2c9597b90803280706g3b69c29h86775dff84e3b559@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <1431279284.1206700704804.JavaMail.jira@brutus>
	 <47ECD57D.6050202@gmail.com> <47ECD970.3080801@gmail.com>
	 <c30d70960803280503i195b5fdaq73768056ee71e5c@mail.gmail.com>
	 <2c9597b90803280515o4005947w2207b63f61cfdf5f@mail.gmail.com>
	 <c30d70960803280538t7f7ebed1kd9b408673d877f3f@mail.gmail.com>
	 <2c9597b90803280706g3b69c29h86775dff84e3b559@mail.gmail.com>

Seems my attachment was lost. Please it attached to HARMONY-5662.

Thanks,
Alexei

2008/3/28, Alexei Zakharov <alexei.zakharov@gmail.com>:
> Looks like I found the guilty manifest, please see attached. It is
>  from "concurrent-1.3.4-patched.jar" that is part of confluence 2.7.1
>  distribution. You may notice that this manifest was created via gcc
>  (?) and follows best practices for all strings in C language -  ends
>  with '\0'. So we get a null-terminated manifest here. :-/
>
>  Can we avoid throwing exception in such cases?
>
>
>  Regards,
>  Alexei
>
>  2008/3/28, Alexei Fedotov <alexei.fedotov@gmail.com>:
>  > Alexei,
>  >  Could you please dump "buf" buffer from InitManifest constructor to
>  >  check if it really contains a null character? If it does, we should
>  >  think how to ignore it smoothly.
>  >
>  >  Thank you in advance.
>  >
>  >
>  >  On Fri, Mar 28, 2008 at 3:15 PM, Alexei Zakharov
>  >  <alexei.zakharov@gmail.com> wrote:
>  >  > I'd like to note here that I don't remember any problems with
>  >  >  manifests loading during confluence startup a couple of months ago
>  >  >  (however, there were other problems). It looks like manifest parsing
>  >  >  routines were significantly updated since then.
>  >  >
>  >  >  Regards,
>  >  >  Alexei
>  >  >
>  >  >  2008/3/28, Alexei Fedotov <alexei.fedotov@gmail.com>:
>  >  >
>  >  >
>  >  > > Alexei's problem (introduced by a patch from [1]) is fixed in my code.
>  >  >  >  He faced another one though.
>  >  >  >
>  >  >  >  [1] http://issues.apache.org/jira/browse/HARMONY-5473
>  >  >  >
>  >  >  >
>  >  >  >
>  >  >  >
>  >  >  >  On Fri, Mar 28, 2008 at 2:41 PM, Tim Ellison <t.p.ellison@gmail.com> wrote:
>  >  >  >  > Tim Ellison wrote:
>  >  >  >  >  > I just committed code in this area (at r641928) so it may indeed be a
>  >  >  >  >  > regression.  Looking...
>  >  >  >  >
>  >  >  >  >  Sorry Alexei, just noticed that your version under test was r640865.
>  >  >  >  >
>  >  >  >  >  Given the recent changes is it possible for you to retry on a later
>  >  >  >  >  version >r641928 since the failing code has been replaced.
>  >  >  >  >
>  >  >  >  >  Thanks,
>  >  >  >  >  Tim
>  >  >  >  >
>  >  >  >  >
>  >  >  >
>  >  >  >
>  >  >  >
>  >  >  >
>  >  >  > --
>  >  >  >  With best regards,
>  >  >  >
>  >  >  > Alexei
>  >  >  >
>  >  >
>  >
>  >
>  >
>  >
>  > --
>  >  With best regards,
>  >
>  > Alexei
>  >
>
>