From dev-return-32377-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Sat Mar 01 20:25:53 2008 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 28584 invoked from network); 1 Mar 2008 20:25:53 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Mar 2008 20:25:53 -0000 Received: (qmail 40877 invoked by uid 500); 1 Mar 2008 20:25:47 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 40851 invoked by uid 500); 1 Mar 2008 20:25:47 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 40840 invoked by uid 99); 1 Mar 2008 20:25:47 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Mar 2008 12:25:47 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of nbeyer@gmail.com designates 209.85.142.190 as permitted sender) Received: from [209.85.142.190] (HELO ti-out-0910.google.com) (209.85.142.190) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Mar 2008 20:25:10 +0000 Received: by ti-out-0910.google.com with SMTP id d10so4839122tib.18 for ; Sat, 01 Mar 2008 12:25:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=eN62Lc1SrFmd0DJBOa+RrQlc/aZ+Nj7NFerzUwKPZXQ=; b=rskPG8oA9pBnVnqspvr+8wPmwPOhEjEtY9oNRB0y6Atewlnky7litRFeM1Cq3YDbO9CMdDc4CEBGiiz/hMEonk02X7BVyftDM6LcfTCVQO/g1HWCJEeUb+aHzMLl0aNbz04JBnV2weYarwcsafNIodnmQKUDZ2ZCrQE5f4mL5sI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=qPW4gj9rvSJhBKr3PP0UXWA5w05tCe2K7oLFv4FsUyEOO5VXjVqailLtd1yRj/nFtvljqiPUJ9zq0qWokt7/DcAlGar9RFJzuhdywAK2ziB8c2CqFqHldILjZEHfFkTWcDD9B9RFd9YuLFsDzPzilDdQJ2jJZCl4RaHYppR+gWc= Received: by 10.150.123.16 with SMTP id v16mr3923319ybc.76.1204403117643; Sat, 01 Mar 2008 12:25:17 -0800 (PST) Received: by 10.150.151.21 with HTTP; Sat, 1 Mar 2008 12:25:17 -0800 (PST) Message-ID: <3b3f27c60803011225o6b1f6d88x8dedca96c77a8c6c@mail.gmail.com> Date: Sat, 1 Mar 2008 14:25:17 -0600 From: "Nathan Beyer" To: dev@harmony.apache.org Subject: Re: [general][website] be careful updating Russian pages In-Reply-To: <0vqfxva43ei.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <2c9597b90802220248s6e80246ale2455a0e4804d2e7@mail.gmail.com> <47BEC5AC.2010505@apache.org> <47C52A79.3070900@gmail.com> <0vqy7934j9g.fsf@gmail.com> <3b3f27c60802291902k684426c9u4a15c953d6163232@mail.gmail.com> <0vqtzjq4xi4.fsf@gmail.com> <3b3f27c60803010844y7c3ffd9cj83000cde367e825f@mail.gmail.com> <0vqfxva43ei.fsf@gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org It's still too easy to make a mistake. The best bet is get the RI's fixed and get the build to force the correct thing. Yes, I do use svn diff, but not on generated code, which is what the HTML files are. In the future, all I'll do is just NOT change these pages. -Nathan On 01 Mar 2008 23:04:21 +0300, Egor Pasko wrote: > On the 0x3FA day of Apache Harmony Nathan Beyer wrote: > > > Here's the change I made - > > http://svn.apache.org/viewvc?view=rev&revision=628236. > > yes, you can see from the patch that Russian text has changed in many > places where was not intended to. So, "svn diff" helped to see > that. This way I kind of proposed the way how one can make sure if > their changes is OK for Russian. Using this technique it is not "too > > easy for people to innocently do the wrong thing here". > > So I do not see the reason of making it completely automatic (since > looking at svn diff is generally a good practice). Automation would be > like put a non-visible test string to the header of each Russian page > and verify that the diff does not contain it. Is it easy? > > But the situation is awkward, I agree. > > > > > On 01 Mar 2008 12:14:11 +0300, Egor Pasko wrote: > > > On the 0x3FA day of Apache Harmony Nathan Beyer wrote: > > > > This happened to me. I don't know Russian, but when I updated the site > > > > for the changes to the ant targets, I figured it was fine to change > > > > the bit that said "ant XXXX". > > > > > > Natan, I did not understand this phrase quite well. Would you, plz, > > > put it in other words so I could understand what happened? I am so > > > sorry :) > > > > > > > > > > -Nathan > > > > > > > > On 29 Feb 2008 23:09:31 +0300, Egor Pasko wrote: > > > > > > > > > > On the 0x3F7 day of Apache Harmony Tim Ellison wrote: > > > > > > Gregory Shimansky wrote: > > > > > > > Alexei Zakharov said the following on 22.02.2008 13:48: > > > > > > >> Hm, I can build Russian pages without any corrupted symbols in it > > > > > > >> using RI on Win32. What this bug is about? > > > > > > > This is a strange bug and it manifests differently on different > > > > > > > windows installations. I think it also depends on your system > > > > > > > language settings on windows. The bug is in wrong generation of > > > > > > > UTF-8 characters for some of Cyrillic letters. See [1] and > > > > > > > predecessors for more details. > > > > > > > [1] http://harmony.markmail.org/message/lcjnldxiisawfzxq > > > > > > > > > > > > Is there any way we can put a check in the build script to ensure the > > > > > > Russian text has not been broken? Even if it is just checking that > > > > > > you are running on a Harmony JRE. > > > > > > > > > > > > It sounds too easy for people to innocently do the wrong thing here. > > > > > > > > > > why? > > > > > > > > > > if you do not know Russian, you probably would not edit it. So, "svn > > > > > diff" would tell you if characters in Russian text changed. And if > > > > > they did, hey, the wrong thing was about to get in :) > > > > > > > > > > -- > > > > > Egor Pasko > > > > > > > > > > > > > > > > > > > > -- > > > Egor Pasko > > > > > > > > > > -- > Egor Pasko > >