harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ilya Berezhniuk" <ilya.berezhn...@gmail.com>
Subject Re: svn commit: r634547 [2/2] - in /harmony/enhanced/drlvm/trunk/vm: em/src/ include/open/ interpreter/src/ jitrino/src/codegenerator/ia32/ jitrino/src/codegenerator/ipf/ jitrino/src/jet/ jitrino/src/shared/ jitrino/src/vm/ vmcore/build/ vmcore/src/c
Date Fri, 07 Mar 2008 16:08:32 GMT
Alexei,

I agree, these type and values look reasonable in the code related to Java.
However, using them everywhere in C/C++ code is not feasible - I hate this.
Specifically, JIT can be used for compiling a code not only from Java
bytecodes...

Thanks,
Ilya.

2008/3/7, Alexei Fedotov <alexei.fedotov@gmail.com>:
> Hello,
>  I vote for not using Boolean at all. jboolean is a part of the
>  standard we are implementing [1] while Boolean is not. The same
>  applies to JNI_TRUE/JNI_FALSE macros in favour of TRUE/FALSE.
>
>  [1] http://java.sun.com/docs/books/jni/html/types.html
>
>
>  On Fri, Mar 7, 2008 at 6:49 PM, Mikhail Fursov <mike.fursov@gmail.com> wrote:
>  > Alexey,
>  >  there is a problem with this commit.
>  >  Some of methods that returns Boolean (that is 'unsigned') are described as
>  >  'bool' in vm_interface.h
>  >  It's not the same and causes problems. For example I found that H2092 fails
>
> [...]
>
>  --
>  With best regards,
>
> Alexei
>

Mime
View raw message