harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: [general][website] be careful updating Russian pages
Date Thu, 13 Mar 2008 14:48:04 GMT
I hear no objections, so I'm going to commit the check.
It requires that you regenerate the website using Harmony so the RU 
pages are not corrupted by the RI.

Regards,
Tim


Tim Ellison wrote:
> Nathan Beyer wrote:
>> Sounds good to me.
>>
>> On 03 Mar 2008 02:25:49 +0300, Egor Pasko <egor.pasko@gmail.com> wrote:
>>> On the 0x3FA day of Apache Harmony Nathan Beyer wrote:
>>>
>>>> It's still too easy to make a mistake. The best bet is get the RI's
>>>  > fixed and get the build to force the correct thing.
>>>  >
>>>  > Yes, I do use svn diff, but not on generated code, which is what the
>>>  > HTML files are. In the future, all I'll do is just NOT change these
>>>  > pages.
>>>
>>>  As a probably convenient alternative, we might require the doc build
>>>  to run under Harmony, so that it breaks otherwise. That way it is not
>>>  too easy to break anything. The error message could say something like:
>>>
>>>  "Building website is not supported on runtimes other than
>>>  Harmony. Please, set your JAVA_HOME accordingly. You can download the
>>>  latest Harmony release here: <...>"
>>>
>>>  How does it sound?
> 
> How about this simple check:
> 
> Index: build.xml
> ===================================================================
> --- build.xml    (revision 632289)
> +++ build.xml    (working copy)
> @@ -55,7 +55,7 @@
> 
>    <target name="site"
>            description="generates the HTML documentation"
> -          >
> +          depends="check-jre">
>        <taskdef name="anakia"
>            classname="org.apache.velocity.anakia.AnakiaTask">
> 
> @@ -139,6 +139,17 @@
> 
>    </target>
> 
> +
> +  <target name="check-jre">
> +      <fail message="You need to generate the site using Harmony">
> +          <condition>
> +              <not>
> +                  <equals arg1="Apache Harmony" 
> arg2="${java.runtime.name}"/>
> +              </not>
> +          </condition>
> +      </fail>
> +  </target>
> +
>  </project>
> 
> 
> 
> Regards,
> Tim
> 

Mime
View raw message