Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of alexey.a.petrenko@gmail.com
 designates 209.85.162.181 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=R0CNeIs1m+N2n5FETiM8DD1WwK8IY/qQiMVCYZSwi6PhknNV2+nNcEN4O8WuHXk+nhlQe46B3uzLAK7Fy4tdlTDsjdpfo5WuZRiONp+DrNNi+bEnC3CUv0rIv7iS5lshcjN3JT7ILGUlJiBBBEhrknr7l1OsCbDJZzWdiIoVjVA=
Message-ID: <c3755b3a0802110515v53a62f70ta05d7c6cdfa5a866@mail.gmail.com>
Date: Mon, 11 Feb 2008 16:15:24 +0300
From: "Alexey Petrenko" <alexey.a.petrenko@gmail.com>
To: dev@harmony.apache.org
Subject: Re: svn commit: r620477 -
 /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/TimeZone.java
In-Reply-To: <47B047CC.9030408@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20080211125241.B92DD1A9832@eris.apache.org>
	 <47B047CC.9030408@gmail.com>

2008/2/11, Tim Ellison <t.p.ellison@gmail.com>:
> Is this the right place to fix the problem?  Why not teach DRLVM to send
> the timezone ID without the trailing newline?
+1

> ayza@apache.org wrote:
> > +        if (zone.contains("\n")) {
> > +            zone = zone.substring(0, zone.indexOf("\n"));
> > +        }
As far as I understood the string ends with "\n".
If so I believe it's better use the following construction here:
if (zone.endsWith("\n"))
    zone = zone.sunstring(0, zone.length() -1);

SY, Alexey