Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (athena.apache.org: domain of alexei.zakharov@gmail.com
 designates 209.85.146.178 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=FplmsIJkLcJZ0Mg8RkBdiqjkAx2LWbMPRlFx66c0lrgOwKarYUZbcAfAkH49U9OtlKUb2M//+M1VxHCkaEKmlKWllQaASmaYHkepbJPeIze0ZnfMPR4LTTS5aGLwa848cVIYYY1qyxKnsddjNAjZErgtpL/OxJE0of/BZXGJ1vo=
Message-ID: <2c9597b90802190216l255482a6h5dc3585e8c56bb01@mail.gmail.com>
Date: Tue, 19 Feb 2008 13:16:42 +0300
From: "Alexei Zakharov" <alexei.zakharov@gmail.com>
To: dev@harmony.apache.org
Subject: Re: [Approval] Commit Harmony-5460
In-Reply-To: <211709bc0802190115q38faf439ra1a6b6125ebd29b2@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <211709bc0802190115q38faf439ra1a6b6125ebd29b2@mail.gmail.com>

Hi Tony,

Don't you think that placing a synchronized block around the existing
code would be a more transparent fix rather than simply redirecting
all job to ICU? I mean something like this:

Index: src/main/java/java/text/MessageFormat.java
===================================================================
--- src/main/java/java/text/MessageFormat.java  (revision 628711)
+++ src/main/java/java/text/MessageFormat.java  (working copy)
@@ -446,6 +446,8 @@
      *                when the pattern cannot be parsed
      */
     public static String format(String template, Object... objects) {
+        String result;
+
         if (objects != null) {
             for (int i = 0; i < objects.length; i++) {
                 if (objects[i] == null) {
@@ -453,12 +455,16 @@
                 }
             }
         }
-        if (format == null) {
-            format = new com.ibm.icu.text.MessageFormat(template);
-        } else if (!template.equals(format.toPattern())){
-            format.applyPattern(template);
+        synchronized (MessageFormat.class) {
+            if (format == null) {
+                format = new com.ibm.icu.text.MessageFormat(template);
+            } else if (!template.equals(format.toPattern())){
+                format.applyPattern(template);
+            }
+            result = format.format(objects);
         }
-        return format.format(objects);
+
+        return result;
     }

     /**


Thanks,
Alexei

2008/2/19, Tony Wu <wuyuehao@gmail.com>:
> This is a major problem which blocks MessageFormat running on
> multi-thread platform. It fails because the caching in Harmony does
> not work with ICU4j 3.8.1. I suggest to commit this patch for M5.
>
> --
> Tony Wu
> China Software Development Lab, IBM
>