harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stepan Mishura" <stepan.mish...@gmail.com>
Subject Re: [APPROVAL] revert r620461
Date Fri, 22 Feb 2008 08:32:12 GMT
On 2/20/08, Alexey Petrenko <alexey.a.petrenko@gmail.com> wrote:
> Guys,
>
> I'm going to revert r620461 because it looks like it causes a
> functional suite failure...
> Any objections?
>

Alexey,

I've checked the reproducer test from HARMONY-5473 with
MANIFEST.MF.txt against the last M5 candidate r629320 and I see:
Uncaught exception in main:
java.io.IOException: Invalid attribute
        at java.util.jar.InitManifest.addAttribute(InitManifest.java:304)
        at java.util.jar.InitManifest.<init>(InitManifest.java:71)
        at java.util.jar.Manifest.read(Manifest.java:173)
        at java.util.jar.Manifest.<init>(Manifest.java:76)
        at test.main(test.java:10)

So for me the patch you applied is invalid  - it didn't fix the issue,
moreover it introduced regression (failed func test).

BTW, this is a good example that it worth to add a regression test for a fix [1]

http://mail-archives.apache.org/mod_mbox/harmony-dev/200802.mbox/%3c6e47b64f0802111942r4f5753e4m29a8535d1532b461@mail.gmail.com%3e

Thanks,
Stepan.

> SY, Alexey
>
> 2008/2/19, Andrey Pavlenko (JIRA) <jira@apache.org>:
> >
> >     [ https://issues.apache.org/jira/browse/HARMONY-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12570167#action_12570167
]
> >
> >  Andrey Pavlenko commented on HARMONY-5473:
> >  ------------------------------------------
> >
> >  It looks like this fix caused a regression - the test http://people.apache.org/~smishura/r620734/Linux_x86_64/func/junit/functional/org/apache/harmony/test/func/api/java/util/jar/Manifest/package-summary.html
failed after the commit.  As mentioned in HARMONY-4419, IOEx should be thrown for \n\r character
sequence.
> >
> >  > [classlib][archive] Manifest file with empty line proves IOException
> >  > --------------------------------------------------------------------
> >  >
> >  >                 Key: HARMONY-5473
> >  >                 URL: https://issues.apache.org/jira/browse/HARMONY-5473
> >  >             Project: Harmony
> >  >          Issue Type: Bug
> >  >          Components: Classlib
> >  >            Reporter: Evgeniya Maenkova
> >  >            Assignee: Alexey Petrenko
> >  >            Priority: Critical
> >  >         Attachments: archive.patch, archive.patch, hyts_manifest1.mf, MANIFEST.MF,
MANIFEST2.MF
> >  >
> >  >
> >  > I cannot start some of my apps, because their jar-files contain manifests
with empty lines, proving IOException on Harmony.
> >  > The situation can be reproduced by manifest file  with empty line creation
and invoking new Manifest(InputStream). Manifest files which proves this will be attached.
> >  > Test case output:
> >  > $ /cygdrive/c/Harmony_to_run/trunk/working_vm/build/win_ia32_msvc_release/deploy/jdk/jre/bin/java
 Test MANIFEST2.MF
> >  > Uncaught exception in main:
> >  > java.io.IOException: Invalid attribute
> >  >         at java.util.jar.InitManifest.addAttribute(InitManifest.java:282)
> >  >         at java.util.jar.InitManifest.<init>(InitManifest.java:71)
> >  >         at java.util.jar.Manifest.read(Manifest.java:173)
> >  >         at java.util.jar.Manifest.<init>(Manifest.java:76)
> >  >         at Test.main(Test.java:8)
> >  > $ /cygdrive/w/UBS/Builds/jdk1.6.0_win32/bin/java Test MANIFEST2.MF
> >  > end
> >  > Test case is:
> >  > import java.io.FileInputStream;
> >  > import java.util.jar.Manifest;
> >  > public class Test {
> >  >     public static void main(String[] args) throws Exception {
> >  >               String fileName = args[0];
> >  >               FileInputStream fs = new FileInputStream(fileName);
> >  >         Manifest m = new Manifest(fs);
> >  >               fs.close();
> >  >               System.out.println("end");
> >  >       }
> >  > }
> >
> >
> >  --
> >  This message is automatically generated by JIRA.
> >  -
> >  You can reply to this email to add a comment to the issue online.
> >
> >
>

Mime
View raw message