harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stepan Mishura" <stepan.mish...@gmail.com>
Subject Re: svn commit: r620461 - /harmony/enhanced/classlib/trunk/modules/archive/src/main/java/java/util/jar/InitManifest.java
Date Tue, 12 Feb 2008 03:42:42 GMT
On 2/11/08, Stepan Mishura <stepan.mishura@gmail.com> wrote:
> Hi Andrey,
>

Ops, sorry Alexey (I've just realized that I used wrong first name)

-Stepan.

> It is very good when a bug is fixed. But IMHO without a regression
> test the fix is not complete - there is a chance to broke accidentally
> fixed functionality again (i.e. introduce a regression). And a
> regression test helps to catch this early.
>
> I think this a good practice to accompany each fix with the regression
> test (of cause if it is possible). The JIRA contains problem
> reproducer. Is it possible to convert is to the unit test?
>
> Thanks,
> Stepan.
>
> -----Original Message-----
> From: apetrenko@apache.org [mailto:apetrenko@apache.org]
> Sent: Monday, February 11, 2008 5:14 PM
> To: commits@harmony.apache.org
> Subject: svn commit: r620461 -
> /harmony/enhanced/classlib/trunk/modules/archive/src/main/java/java/util/jar/InitManifest.java
>
> Author: apetrenko
> Date: Mon Feb 11 03:14:08 2008
> New Revision: 620461
>
> URL: http://svn.apache.org/viewvc?rev=620461&view=rev
> Log:
> Patch for HARMONY-5473 "[classlib][archive] Manifest file with empty
> line proves IOException"
>
> Modified:
>    harmony/enhanced/classlib/trunk/modules/archive/src/main/java/java/util/jar/InitManifest.java
>
> Modified: harmony/enhanced/classlib/trunk/modules/archive/src/main/java/java/util/jar/InitManifest.java
> URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/archive/src/main/java/java/util/jar/InitManifest.java?rev=620461&r1=620460&r2=620461&view=diff
> ==============================================================================
> --- harmony/enhanced/classlib/trunk/modules/archive/src/main/java/java/util/jar/InitManifest.java
> (original)
>
> <SNIP>
>

Mime
View raw message