harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy,Jing Lv" <firep...@gmail.com>
Subject Re: [jdktools][jdwp] New JVMTI functions for Java 6
Date Fri, 29 Feb 2008 08:22:43 GMT
It seems we can test on RI, I suggest commit the patch then.

2008/2/29, Sean Qiu <sean.xx.qiu@gmail.com>:
> +1
>  Good idea.
>
>  2008/2/27, Jimmy,Jing Lv <firepure@gmail.com>:
>
> > Hi,
>  >
>  > 2008/2/27, Sean Qiu <sean.xx.qiu@gmail.com>:
>  > > I can build and test the patch with ibm vm and modified jvmti.h. But
>  > >
>  > >  1.Committer cann't build it, since there is no related function in
>  > >  current jvmti.h
>  > >  2. Committer cann't run the test, since our drlvm has not implemented
>  > >  the function.
>  > >
>  > >  So the question is how can i commit the patch to our community?
>  > >  My proposal is i can upload another temporary patch to update the
>  > >  jvmti.h in luni module for testing. And the committer can build it and
>  > >  use ibm vm to test it.
>  > >
>  >
>  > I agree that we can make a little modification in jvmti.h to make JDWP
>  > new code build, but these mock shall not used to pass the testcases
>  > (Do drlvm gurus have a plan on JVMTI uplift?)
>  > And it seems the current ibm vme on Harmony does not support Java6
>  > JVMTI either (Can RI be used for testing?)
>  > However I'd like help to test your patch and commit them. Thanks.
>  >
>  > >  Does it make sense? Any suggestions or comments?
>  > >
>  > >
>  > >
>  > >  2008/2/26, Sean Qiu <sean.xx.qiu@gmail.com>:
>  > >  > It is quite helpful, thanks.
>  > >  >
>  > >  > 2008/2/26, Gregory Shimansky <gshimansky@apache.org>:
>  > >  > > Eugene Ostrovsky said the following on 26.02.2008 10:51:
>  > >  > > > Hi,
>  > >  > > >
>  > >  > > > Java 6 JVMTI features are not implemented in drlvm.
>  > >  > > >
>  > >  > > > Could you please provide a list of JVMTI 6 functions that
are critical
>  > >  > > > for JDWP 6?
>  > >  > >
>  > >  > > Just for the reference, here's a list of Java6 enhancements in
JVMTI [1]
>  > >  > >
>  > >  > > [1] http://java.sun.com/javase/6/docs/technotes/guides/jvmti/changes6.html
>  > >  > >
>  > >  > > > On Tue, Feb 26, 2008 at 10:24 AM, Sean Qiu <sean.xx.qiu@gmail.com>
wrote:
>  > >  > > >> For example, The new ClassFileVersion Command (17) in
JDWP need to
>  > >  > > >>  invoke the new Java 6 jvmti function:
>  > >  > > >>  jvmtiError GetClassVersionNumbers(jvmtiEnv* env,
>  > >  > > >>             jclass klass,
>  > >  > > >>             jint* minor_version_ptr,
>  > >  > > >>             jint* major_version_ptr).
>  > >  > > >>
>  > >  > > >>  We cannot find it in the current Java 5 jvmti.h.
>  > >  > > >>  And the other new added commands have the same problem.
>  > >  > > >>
>  > >  > > >>
>  > >  > > >>  2008/2/26, Sean Qiu <sean.xx.qiu@gmail.com>:
>  > >  > > >>  >
>  > >  > > >>
>  > >  > > >>
>  > >  > > >>> Hi, drlvm gurus
>  > >  > > >>  >
>  > >  > > >>  > Do we have implemented the JVMTI updates for Java
6?
>  > >  > > >>  > Since the JDWP updates depends on the JVMTI new
functions.
>  > >  > > >>  >
>  > >  > > >>  > Thanks very much.
>  > >  > > >>  >
>  > >  > > >>  > --
>  > >  > > >>  > Sean, Xiao Xia Qiu
>  > >  > > >>  > China Software Development Lab, IBM
>  > >  > > >>
>  > >  > > >>
>  > >  > > >>
>  > >  > > >>  --
>  > >  > > >>  Sean, Xiao Xia Qiu
>  > >  > > >>  China Software Development Lab, IBM
>  > >  > > >>
>  > >  > >
>  > >  > >
>  > >  > > --
>  > >  > > Gregory
>  > >  > >
>  > >  > >
>  > >  >
>  > >  >
>  > >  > --
>  > >  > Sean, Xiao Xia Qiu
>  > >  > China Software Development Lab, IBM
>  > >  >
>  > >
>  > >
>  > >
>  > > --
>  > >
>  > > Sean, Xiao Xia Qiu
>  > >  China Software Development Lab, IBM
>  > >
>  >
>  >
>  > --
>  >
>  > Best Regards!
>  >
>  > Jimmy, Jing Lv
>  > China Software Development Lab, IBM
>  >
>
>
>
> --
>
> Sean, Xiao Xia Qiu
>  China Software Development Lab, IBM
>


-- 

Best Regards!

Jimmy, Jing Lv
China Software Development Lab, IBM

Mime
View raw message