harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Zakharov" <alexei.zakha...@gmail.com>
Subject Re: svn commit: r620477 - /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/TimeZone.java
Date Mon, 11 Feb 2008 14:21:30 GMT
FYI I've marked the fix as a "workaround" in JIRA. I'll create new
DRLVM issue with detailed description of the problem. I promise to
roll back this workaround as soon as we have this issue fixed in
DRLVM. Does this make sense?

Regards,
Alexei

2008/2/11, Tim Ellison <t.p.ellison@gmail.com>:
> Alexey Petrenko wrote:
> > 2008/2/11, Tim Ellison <t.p.ellison@gmail.com>:
> >> Is this the right place to fix the problem?  Why not teach DRLVM to send
> >> the timezone ID without the trailing newline?
> > +1
> >
> >> ayza@apache.org wrote:
> >>> +        if (zone.contains("\n")) {
> >>> +            zone = zone.substring(0, zone.indexOf("\n"));
> >>> +        }
> > As far as I understood the string ends with "\n".
> > If so I believe it's better use the following construction here:
> > if (zone.endsWith("\n"))
> >     zone = zone.sunstring(0, zone.length() -1);
>
> If we can fix DRLVM by M5 then I suggest we don't need the workaround at
> all.  Otherwise leave it in but leave the JIRA open and redirect it to
> DRLVM with a reminder to remove the workaround when fixed properly.
>
> Regards,
> Tim
>
>
>

Mime
View raw message