Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 28905 invoked from network); 10 Jan 2008 15:14:57 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Jan 2008 15:14:57 -0000 Received: (qmail 97511 invoked by uid 500); 10 Jan 2008 15:14:44 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 97485 invoked by uid 500); 10 Jan 2008 15:14:44 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 97476 invoked by uid 99); 10 Jan 2008 15:14:44 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Jan 2008 07:14:44 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of t.p.ellison@gmail.com designates 72.14.214.236 as permitted sender) Received: from [72.14.214.236] (HELO hu-out-0506.google.com) (72.14.214.236) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Jan 2008 15:14:20 +0000 Received: by hu-out-0506.google.com with SMTP id 27so292085hub.15 for ; Thu, 10 Jan 2008 07:14:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding; bh=yNBtJsAc1Br4Lzt9/yUOTOjFPZZVrxMwlLAAkPhLm2A=; b=RQznItDyGoKVQfQ0hQbdv8leMFi/p3o3XPqNTMxNMiSZkzBKz9vDGW30qwZOdowD4O0r47OlPi76KO0+E/zH1fZviuPSvlz3iy1LV92iecAh3OJM4WC9EYV9Dh06J5FKTMbleLTbl7/1SUOi9qrFpqXCDlD+CpGL1oxA1D6iQQE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding; b=Wt04CibiB+w3Swq77K0HdzCWFYhYZW90zpFA7goTJMi7ZKDUTe3mum1v8XNgkt3wz2iiH2c1zxQim+VwZzv6/TWl8VqZVeAhMKWlVtI6J24d4rxRqTlSRp96klS8zW/ZSZRPWg3WHvqbmzJWMYXxhHJkzUamTv+BZcc2WC/dhhA= Received: by 10.66.244.2 with SMTP id r2mr3598112ugh.64.1199978065064; Thu, 10 Jan 2008 07:14:25 -0800 (PST) Received: from ?9.20.183.163? ( [195.212.29.92]) by mx.google.com with ESMTPS id k2sm2824941ugf.12.2008.01.10.07.14.23 (version=SSLv3 cipher=RC4-MD5); Thu, 10 Jan 2008 07:14:24 -0800 (PST) Message-ID: <4786364E.8070706@gmail.com> Date: Thu, 10 Jan 2008 15:14:22 +0000 From: Tim Ellison User-Agent: Thunderbird 2.0.0.9 (Windows/20071031) MIME-Version: 1.0 To: dev@harmony.apache.org Subject: Re: [external] One more opportunity of QA for Harmony References: <4bebff790801100340w526ca21ey5da0e2582d984bcd@mail.gmail.com> <4bebff790801100512n5405e53enfd23a92788883c7b@mail.gmail.com> In-Reply-To: X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Sian January wrote: > I think it would be really good to scan the classlib code. I spent some > time last year fixing bugs found by FindBugs and although a lot of them were > minor there were a handful of quite serious ones that were definitely worth > the time spent. There is a fair amount of manual post-evaluation work, but > surely it can't hurt to get the report and then fix the issues as and when > people have time. The key is to do as you did though, and document those "false positives" in a way that they are removed from subsequent analyses. There are a number of places in implementing the core class libraries themselves that require techniques which would be considered bad practice for application coding. Regards, Tim