From dev-return-31487-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Thu Jan 10 16:04:08 2008 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 54445 invoked from network); 10 Jan 2008 16:04:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 10 Jan 2008 16:04:08 -0000 Received: (qmail 95356 invoked by uid 500); 10 Jan 2008 16:03:56 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 95325 invoked by uid 500); 10 Jan 2008 16:03:55 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 95316 invoked by uid 99); 10 Jan 2008 16:03:55 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Jan 2008 08:03:55 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of mloenko@gmail.com designates 209.85.134.187 as permitted sender) Received: from [209.85.134.187] (HELO mu-out-0910.google.com) (209.85.134.187) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Jan 2008 16:03:32 +0000 Received: by mu-out-0910.google.com with SMTP id w8so400818mue.1 for ; Thu, 10 Jan 2008 08:03:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=YPkh+wcCB20o1xDZBYxllyTiqafVrgb8CDlIPgEaRT0=; b=ZaxhmltZO7kJ7TkA/GUy6zbzDiBry0rZawVp6cNlVJuVFgxHd9eEKZi+9vIfv7Q52VM4LjvEbAcSU35K4cX1OvG7eAugh1BpgoiKLeQWpItpatyOks0JjaHTn1qTFe1gbAOSG+BxFtX61CaWAptwnUkZN1jLU8vUHZ7qjJjhJvo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=sMvS+4LLZVz7OZ8KzxaKQ5Lu9pTZpuL34c4Fxph9pvyLEyHluDPUA66hhlLug888r4smaaQpTlQrNenKQAiZHHF8Q+altPcnmPKK3KlxELXuwKiswjoeNmn8wi/YOsm70WtDXOxf7DMo3LpBMU8vh943MU8cnaOWVx3I0Rj73qU= Received: by 10.78.138.6 with SMTP id l6mr2453698hud.32.1199981014614; Thu, 10 Jan 2008 08:03:34 -0800 (PST) Received: by 10.78.14.11 with HTTP; Thu, 10 Jan 2008 08:03:34 -0800 (PST) Message-ID: <906dd82e0801100803i4c531d95k1d8c64fe4937f896@mail.gmail.com> Date: Thu, 10 Jan 2008 22:03:34 +0600 From: "Mikhail Loenko" To: dev@harmony.apache.org Subject: Re: svn commit: r610727 - in /harmony/enhanced/drlvm/trunk/vm/vmcore/src: class_support/Environment.cpp init/vm_properties.cpp In-Reply-To: <47860EBC.8020001@apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080110091321.373E81A9850@eris.apache.org> <47860EBC.8020001@apache.org> X-Virus-Checked: Checked by ClamAV on apache.org We should revert it once we have more testing results. When we know all the failures we can continue bugfix for the uncompressed mode 2008/1/10, Gregory Shimansky : > Hello > > This switch to uncompressed references by default broke several > regression tests that run on JIT in server mode. For example running > test for H3228 crashes on assertion in JIT: > > #0 0x00002b5992689b75 in raise () from /lib64/libc.so.6 > #1 0x00002b599268b060 in abort () from /lib64/libc.so.6 > #2 0x00002b5992683246 in __assert_fail () from /lib64/libc.so.6 > #3 0x00002aaaad23ab70 in Jitrino::HelperInliner::run (this=0xfd9fd0) at > /nfs/ims/proj/drl/mrt2/users/gregory/em64t/trunk/working_vm/vm/jitrino/src/optimizer/helper_inliner.cpp:207 > #4 0x00002aaaad23b808 in Jitrino::HelperInlinerSession::_run > (this=0xfdef88, irm=@0xf4cc80) at > /nfs/ims/proj/drl/mrt2/users/gregory/em64t/trunk/working_vm/vm/jitrino/src/optimizer/helper_inliner.cpp:200 > #5 0x00002aaaad27fb31 in Jitrino::OptPass::run (this=0xfdef88) at > /nfs/ims/proj/drl/mrt2/users/gregory/em64t/trunk/working_vm/vm/jitrino/src/optimizer/optpass.cpp:62 > #6 0x00002aaaad137b0d in Jitrino::runPipeline (c=0x42410440) at > /nfs/ims/proj/drl/mrt2/users/gregory/em64t/trunk/working_vm/vm/jitrino/src/main/Jitrino.cpp:224 > #7 0x00002aaaad137ba4 in Jitrino::compileMethod (cc=0x42410440) at > /nfs/ims/proj/drl/mrt2/users/gregory/em64t/trunk/working_vm/vm/jitrino/src/main/Jitrino.cpp:241 > #8 0x00002aaaad137c54 in Jitrino::Jitrino::CompileMethod > (cc=0x42410440) at > /nfs/ims/proj/drl/mrt2/users/gregory/em64t/trunk/working_vm/vm/jitrino/src/main/Jitrino.cpp:258 > > > Looking at the helper_inliner.cpp:207 I see the following code: > > #ifdef _EM64T_ > assert(VMInterface::areReferencesCompressed()); > #endif > > which probably means that it is just not ready for uncompressed > references mode. I want to ask JIT developers, whether it is easy to > quickly fix this, or should we revert switching to uncompressed > references as the default mode? > > smishura@apache.org said the following on 10.01.2008 12:13: > > Author: smishura > > Date: Thu Jan 10 01:12:41 2008 > > New Revision: 610727 > > > > URL: http://svn.apache.org/viewvc?rev=610727&view=rev > > Log: > > Apply patch from HARMONY-5355: > > [drlvm][object][testing] Change default references mode to uncompressed on x86-64 > > > > Modified: > > harmony/enhanced/drlvm/trunk/vm/vmcore/src/class_support/Environment.cpp > > harmony/enhanced/drlvm/trunk/vm/vmcore/src/init/vm_properties.cpp > > > > Modified: harmony/enhanced/drlvm/trunk/vm/vmcore/src/class_support/Environment.cpp > > URL: http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/vm/vmcore/src/class_support/Environment.cpp?rev=610727&r1=610726&r2=610727&view=diff > > ============================================================================== > > --- harmony/enhanced/drlvm/trunk/vm/vmcore/src/class_support/Environment.cpp (original) > > +++ harmony/enhanced/drlvm/trunk/vm/vmcore/src/class_support/Environment.cpp Thu Jan 10 01:12:41 2008 > > @@ -126,7 +126,7 @@ > > use_lil_stubs = true; > > #ifdef REFS_USE_RUNTIME_SWITCH > > #ifdef POINTER64 > > - compress_references = true; > > + compress_references = false; > > #else // POINTER64 > > compress_references = false; > > #endif // POINTER64 > > > > Modified: harmony/enhanced/drlvm/trunk/vm/vmcore/src/init/vm_properties.cpp > > URL: http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/vm/vmcore/src/init/vm_properties.cpp?rev=610727&r1=610726&r2=610727&view=diff > > ============================================================================== > > --- harmony/enhanced/drlvm/trunk/vm/vmcore/src/init/vm_properties.cpp (original) > > +++ harmony/enhanced/drlvm/trunk/vm/vmcore/src/init/vm_properties.cpp Thu Jan 10 01:12:41 2008 > > @@ -303,7 +303,7 @@ > > properties.set_new("thread.soft_unreservation", "false"); > > > > #ifdef REFS_USE_RUNTIME_SWITCH > > - properties.set_new("vm.compress_references", "true"); > > + properties.set_new("vm.compress_references", "false"); > > #endif > > > > int n_api_dll_files = sizeof(api_dll_files) / sizeof(char *); > > > > > >