harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sian January" <sianjanu...@googlemail.com>
Subject Re: [external] One more opportunity of QA for Harmony
Date Fri, 11 Jan 2008 11:34:59 GMT
Yes - I know that some of those places had appropriate comments, but they
didn't all have so it's definitely worth being careful when making
changes in the core classes in luni.


On 10/01/2008, Tim Ellison <t.p.ellison@gmail.com> wrote:
>
> Sian January wrote:
> > I think it would be really good to scan the classlib code.  I spent some
> > time last year fixing bugs found by FindBugs and although a lot of them
> were
> > minor there were a handful of quite serious ones that were definitely
> worth
> > the time spent.  There is a fair amount of manual post-evaluation work,
> but
> > surely it can't hurt to get the report and then fix the issues as and
> when
> > people have time.
>
> The key is to do as you did though, and document those "false positives"
> in a way that they are removed from subsequent analyses.  There are a
> number of places in implementing the core class libraries themselves
> that require techniques which would be considered bad practice for
> application coding.
>
> Regards,
> Tim
>
>


-- 
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message