harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Qiu" <sean.xx....@gmail.com>
Subject Re: [buildtest] does the buildtest 2.0 work with an 1.7
Date Mon, 24 Dec 2007 05:48:19 GMT
Yes. The root of the problem is that the behavior of task
*<xmlproperty>*is changed in  ANT
1.7.0.

Loading parameters.xml [1] property file with ant, the value of "
parameter.required.noupdate" is different between version 1.6.5 and 1.7.0 of
ANT. In the case of 1.6.5, value of the property is *unset *but *"" *in
1.7.0.

So the expression in framework.xml [2] will always return false,It makes
that the "*do-svn-update-bt*" unreachable and the script cannot find the
tests directory before checking it out.

I have reported a jira [3] and supplied the patch.

1. parameters.xml
<parameters>
    <required/>
        <noupdate description="Turns off local BTI repository updates on
'install' and 'setup' stages."/>
    </repository>
</parameters>

2. framework.xml
            <if>
                 <and>
                    <not><isset property="
framework.parameters.repository.noupdate"/></not>
                     <not><contains string="${
framework.parameters.repository.awaited}"
                                    substring="|${tmp.relative.path
}|"/></not>
                 </and>
            <then>
                <do-svn-update-bt path="${tmp.relative.path}"/>
            </then>
            </if>

3.https://issues.apache.org/jira/browse/HARMONY-5337

2007/12/21, Stepan Mishura <stepan.mishura@gmail.com>:
> On 12/21/07, Sean Qiu <sean.xx.qiu@gmail.com> wrote:
> > It seems that <svn-update-bt path="${test.sources.dir}/${suite.name }"/>
> > cannot check out the tests.
>
> Do you mean fail with ANT 1.7? I assume it works OK with 1.6.5.
>
> -Stepan.
>
> > The gut adaptor has the same problem and fails for the same error.
> >
> > I will dive into this issues to find out a solution later.
> >
> > 2007/12/21, Sean Qiu <sean.xx.qiu@gmail.com>:
> > >
> > > "#>./buildtest.sh install" will call target update-framework[1] of
> > > build.xml.
> > > Update-framework only update the <root>/scripts and <root>/adaptors
in
> > > BTI,
> > > while many tests as well as configurations are in <root>/tests
directory.
> > > Missing <root>/tests cause the build error.
> > >
> > > The reason we do not update <root>/tests directly in install step is
if we
> > > just want to run a single test suite,
> > > it will be unnecessary to check out all of the tests, since it is
> > > time-comsuming.
> > >
> > > So the "setup" target of adaptor of each test suite is supposed to
check
> > > out individual tests themselves
> > > within <svn-update-bt path="${test.sources.dir}/${suite.name }"/>.
> > > And it is missing in maven adaptor, so i guess it is my fault.
> > >
> > > Generally, i will using "svn co" rather than "svn co -N" to develop a
new
> > > adaptor.
> > > This will download the whole tests directly, so i overlook this
problem.
> > > I will supply a patch for maven test  as well as all the other
adaptors i
> > > raised.
> > >
> > > Thanks very much to point it out.
> > >
> > > 1. update-framework of build.xml
> > >
> > >     <target name="update-framework"
> > >             unless="framework.parameters.repository.noupdate">
> > >         <!-- do update of framework implementation and test suite
> > >              integration scripts -->
> > >         <exec executable="svn" dir="${ root.dir}" failonerror="true">
> > >             <arg line="update ${scripts.dir} ${adaptors.dir}"/>
> > >         </exec>
> > >     </target>
> > >
> > > 2007/12/21, Nathan Beyer < nbeyer@gmail.com>:
> > > >
> > > > The README doesn't say I need to checkout that folder and it's very
> > > > specific about the checkout command using the "-N" to NOT check out
> > > > any sub-folder. Is the documentation wrong? I'm specifically try to
> > > > get this thing to work out of the box because we need to get
buildtest
> > > > 2.0 out of permanent branch and back into the trunk.
> > > >
> > > > On my Windows machine, I switched to Ant 1.6.5 and ran the same
> > > > commands and a lot more is happening now; it checked out the
> > > > 'tests/maven_test' folder and began a build.
> > > >
> > > > -Nathan
> > > >
> > > > On Dec 20, 2007 9:46 PM, Sean Qiu <sean.xx.qiu@gmail.com> wrote:
> > > > > I have tried this adaptor, it works fine here.
> > > > >
> > > > > And once i rename the <root>/tests/maven_tests to other name,
it
will
> > > > fail
> > > > > with the same error message as you.
> > > > > The reason should be that the adaptor cannot find this directory.
> > > > > So I guess you may have not checked out the directory of
> > > > > <root>/tests/maven_test .
> > > > >
> > > > > Could you please check it out first and try again?
> > > > >
> > > > > 2007/12/21, Nathan Beyer <ndbeyer@apache.org>:
> > > > >
> > > > > >
> > > > > > I'm having all sorts of issues with buildtest 2.0. Here's what
I'm
> > > > > > running, is there anything that's out of whack?
> > > > > >
> > > > > > Ubuntu 7.10 on x86_64 (AMD dual core)
> > > > > > Sun Java 1.6
> > > > > > Ant 1.7
> > > > > > SVN 1.4.4
> > > > > >
> > > > > > Windows XP on x86
> > > > > > Sun Java 1.6
> > > > > > MSVC 2003
> > > > > > Ant 1.7
> > > > > > SVN 1.4.5
> > > > > >
> > > > > > Here's what I'm doing, per the README [1].
> > > > > >
> > > > > > * svn checkout -N
> > > > > >
> > > >
https://svn.apache.org/repos/asf/harmony/enhanced/buildtest/branches/2.0/
> > > > > > * Tweak the buildtest.sh to setup the environment variables
and
then
> > > > > > run these commands.
> > > > > > * ./buildtest.sh install
> > > > > > * ./buildtest.sh setup -Dtest.suites="classlib,drlvm,maven_test"
> > > > > > * ./buildtest.sh run
> > > > > >
> > > > > > Here's the failure I get --
> > > > > >
> > > > > >
> > > > > > -install:
> > > > > >      [echo]
> > > > > >      [echo] --------
> > > > > >      [echo] WARNING: Target setup of adaptor for Test Suite
> > > > 'maven_test'
> > > > > > FAILED
> > > > > >      [echo] -------- with the following exception:
> > > > > >      [echo] The following error occurred while executing this
line:
> > > > > >      [echo] /home/nathan/harmony/bti/scripts/framework.xml:1079:
> > > > > > /home/nathan/harmony/bti/tests/maven_test is not a valid
directory
> > > > > >    [delete] Deleting:
> > > > /home/nathan/harmony/bti/build/temp/null1764598389
> > > > > >
> > > > > > check-status:
> > > > > >      [echo]
> > > > > >      [echo] ------
> > > > > >      [echo] ERROR: Setup of Test Suite 'maven_test' FAILED.
> > > > > >      [echo] ------
> > > > > >
> > > > > > BUILD FAILED
> > > > > >
> > > > > > The same failure happened on windows; the paths were just a
bit
> > > > different.
> > > > > >
> > > > > > I thought this was supposed to work out of the box.
> > > > > >
> > > > > > -Nathan
> > > > > >
> > > > > > [1]
> > > > > >
> > > >
https://svn.apache.org/repos/asf/harmony/enhanced/buildtest/branches/2.0/README.txt
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Sean Qiu
> > > > > http://xiaoxia.turendui.com
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Sean Qiu
> > > http://xiaoxia.turendui.com
> > >
> >
> >
> >
> > --
> > Sean Qiu
> > http://xiaoxia.turendui.com
>



-- 
Sean Qiu
http://xiaoxia.turendui.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message