From dev-return-30483-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Fri Nov 09 10:31:56 2007 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 4120 invoked from network); 9 Nov 2007 10:31:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 9 Nov 2007 10:31:56 -0000 Received: (qmail 72690 invoked by uid 500); 9 Nov 2007 10:31:43 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 72666 invoked by uid 500); 9 Nov 2007 10:31:43 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 72657 invoked by uid 99); 9 Nov 2007 10:31:43 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Nov 2007 02:31:43 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of wuyuehao@gmail.com designates 209.85.128.185 as permitted sender) Received: from [209.85.128.185] (HELO fk-out-0910.google.com) (209.85.128.185) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Nov 2007 10:31:46 +0000 Received: by fk-out-0910.google.com with SMTP id 18so424063fks for ; Fri, 09 Nov 2007 02:31:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=3avX/O/rl5OSJwBZLBrqYYv1+sJbwP+GlpQLon+PzsA=; b=AlMetcKCGiJofY5TwNUyWGb0YIIjfLBYFSpcwa7cc3pftgJ4jzMfo1x+cb8LIS5U2IM2M1CulWbkZhr3GVed3UaFXHcm+pl+dCyDqjb36Y5TFkEIdm1psbREsPgMQYbLJH8jLgTLkARIP3cx41zBxo9hOlkFbSghjt2fcKxHyR8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=d+A2GnylH4EEXEKFffZn1xNqKVAOVx5iSB3q9UnrayKseW6QtmD1Ea94TeYFmNBsjxbjvBEuCmof0rSgwe1vO6+rl+aMSSA4HGBCw1eKj7lvgzjc0G5wO25ykdZ2C1TBej52yhvFcUrnDAcUgyru45rnPxED0tvAAEue53TmXuQ= Received: by 10.82.107.15 with SMTP id f15mr3615915buc.1194604284769; Fri, 09 Nov 2007 02:31:24 -0800 (PST) Received: by 10.82.141.19 with HTTP; Fri, 9 Nov 2007 02:31:24 -0800 (PST) Message-ID: <211709bc0711090231y51dbfac6kd45116da5361b2a@mail.gmail.com> Date: Fri, 9 Nov 2007 18:31:24 +0800 From: "Tony Wu" To: dev@harmony.apache.org Subject: Re: [classlib]remove the duplicate locale data In-Reply-To: <211709bc0711080306p7783d541jebe8398bf18e7693@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <211709bc0711050033o55158d22mad9dce73f8ad4490@mail.gmail.com> <47305354.6090603@gmail.com> <211709bc0711060623k7a7ed510u4a650adfd9ce914f@mail.gmail.com> <211709bc0711060636w532d2a43nea95f9ea77be345b@mail.gmail.com> <200711071321.lA7DL2Z4002557@d12av01.megacenter.de.ibm.com> <211709bc0711071926h2a465527v2072f0d5f96af614@mail.gmail.com> <200711080751.lA87pJKu018163@d12av04.megacenter.de.ibm.com> <211709bc0711080306p7783d541jebe8398bf18e7693@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org This bug is caused by different timezone data, I've fixed it at r593469 along with some difference form RI(failures on RI, I just modified the testcases and now they can passed on both sides). On 11/8/07, Tony Wu wrote: > On 11/8/07, Mark Hindess wrote: > > > > On 8 November 2007 at 11:26, "Tony Wu" wrote: > > > > > > Hi Mark, I can not reproduce it on my winxp and ubuntu. I believe > > > it caused by the default timezone. would you pls take a look at the > > > current timezone when it fails and whether it passes on RI? thanks a > > > lot! > > > > Timezone is "Europe/London". And (as I mentioned below ;-) it passes on > > RI. > > OK, I found that the output of following code is different for RI and > Harmony, still investigating... > > TimeZone timezone = TimeZone.getTimeZone("Europe/London"); > System.out.println(timezone.getOffset(0)); > > RI > 3600000 > Harmony > 0 > > > > > -Mark > > > > > On 11/7/07, Mark Hindess wrote: > > > > > > > > I'm seeing a failure on Linux where the first test in: > > > > > > > > tests.api.java.util.DateTest.test_toString > > > > > > > > is failing because the result is: > > > > > > > > Thu Jan 01 01:00:00 GMT+01:00 1970 > > > > > > > > rather than: > > > > > > > > Thu Jan 01 00:00:00 GMT 1970 > > > > > > > > Am I the only one seeing this? The test passes on the RI. > > > > > > > > -Mark. > > > > > > > > On 6 November 2007 at 22:36, "Tony Wu" wrote: > > > > > I've committed the patch at r592434. > > > > > the excluded classes are, > > > > > > > > > > tests.api.java.util.CurrencyTest > > > > > tests.api.java.util.FormatterTest > > > > > tests.api.java.util.GregorianCalendarTest > > > > > tests.api.java.util.LocaleTest > > > > > tests.api.java.util.ScannerTest > > > > > > > > > > org.apache.harmony.text.tests.java.text.DecimalFormatSymbolsTest > > > > > org.apache.harmony.text.tests.java.text.NumberFormatTest > > > > > org.apache.harmony.text.tests.java.text.SimpleDateFormatTest > > > > > > > > > > pls kindly let me know if you find any problem, thanks. > > > > > > > > > > On 11/6/07, Tony Wu wrote: > > > > > > On 11/6/07, Tim Ellison wrote: > > > > > > > Tony Wu wrote: > > > > > > > > I've raised a JIRA[1] for migrating the dependencies of locale rela > > > ted > > > > > > > > data to icu4j and remove the data in > > > > > > > > luni/src/main/java/org/apache/harmony/luni/internal/locale/. Curren > > > tly > > > > > > > > I have delegated all the locale related classes to corresponding > > > > > > > > classes in icu4j and successfully removed the dependencies of harmo > > > ny > > > > > > > > resource bundles. > > > > > > > > > > > > > > Cool -- this is good because it removes the code duplication we have > > > at > > > > > > > present, it shifts the maintenance of the locale data into the right > > > > > > > place (IMHO) that being the ICU project, and gives us the opportunity > > > to > > > > > > > use the ICU tools to customize/refresh/etc the data for Harmony each > > > > > > > time the USA decide to introduce another daylight savings change ;-) > > > > > > > > > > > > exactly. > > > > > > > > > > > > > > > As expected, there are around 20 failures of harmony test. Many of > > > > > > > > them are caused by data difference. I've listed all of them on harm > > > ony > > > > > > > > wiki[2] and will raise them to icu soon. > > > > > > > > > > > > > > Ack. I believe that (pretty much) everyone gets the data from the CL > > > DR, > > > > > > > so I would expect any differences to be tests that have out of date > > > > > > > assumptions about the data. > > > > > > > > > > > > Yes, I'll check it based on CLDR. > > > > > > > > > > > > > > > By applying this patch, we can get 4.2 mega bytes decrease in harmo > > > ny > > > > > > > > source code, including the svn data. > > > > > > > > > > > > > > ooh, say that again! Removing 4.2Mb of redundant source code is exce > > > llen > > > > > t. > > > > > > > > > > > > > > > My proposal is to apply the patch on 5061 first and exclude these > > > > > > > > tests which fail on different locale data. Then I'll take follow up > > > > > > > > action to contact icu team and get solution to move them out. > > > > > > > > Otherwise I'm afraid my fix will be outdated for waiting until icu > > > > > > > > team get ready to fix the data. Do you have any objection? > > > > > > > > > > > > > > > > Later, I'll take care of the performance issue of this delegation. > > > > > > > > > > > > > > > > Thanks in advance for your comments > > > > > > > > > > > > > > Sounds like a good plan. > > > > > > > > > > > > > > Regards, > > > > > > > Tim > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Tony Wu > > > > > > China Software Development Lab, IBM > > > > > > > > > > > > > > > > > > > > > -- > > > > > Tony Wu > > > > > China Software Development Lab, IBM > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > Tony Wu > > > China Software Development Lab, IBM > > > > > > > > > > > > -- > Tony Wu > China Software Development Lab, IBM > -- Tony Wu China Software Development Lab, IBM