From dev-return-30452-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Thu Nov 08 05:53:55 2007 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 46482 invoked from network); 8 Nov 2007 05:53:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 8 Nov 2007 05:53:55 -0000 Received: (qmail 13874 invoked by uid 500); 8 Nov 2007 05:53:42 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 13851 invoked by uid 500); 8 Nov 2007 05:53:42 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 13842 invoked by uid 99); 8 Nov 2007 05:53:41 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Nov 2007 21:53:41 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of wuyuehao@gmail.com designates 209.85.128.185 as permitted sender) Received: from [209.85.128.185] (HELO fk-out-0910.google.com) (209.85.128.185) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Nov 2007 05:53:45 +0000 Received: by fk-out-0910.google.com with SMTP id 18so45221fks for ; Wed, 07 Nov 2007 21:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=YwCNSGdxkgb5B9BlcJyAOJzg0DThXXt0AIFt2jMxR+8=; b=Q/kMkd+360G5IF92cn3gSskw9H2Lp0VT+bn23YlEz5oTDSBoouejiB+IiJ7d+RTUrNijIYwr0ALVOLdJFDNolhBHjybv1TT+6NvInm22OEriQLQS32Qii18Ls0iQX4YkOufJdo5TqOw7Tbj15k+tii7Nl1m2wB6RseKAxdK/sTQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=FohRGOdHLF4lu60OpNnIwTrDH8vWPevYO+KG2Xzi438zPyvdD/IVBx5j2/ScXPxITX3VbAzNb7tVhV3g2w4b0Eww4sJJcmTE+jzp6W6OFBLMVF3REf7/jz/ApadbnXMYsb1t9JhgSjFrN2QiysiAGiWovUrNIzYcyknVJ71uJeI= Received: by 10.82.138.6 with SMTP id l6mr460939bud.1194501202930; Wed, 07 Nov 2007 21:53:22 -0800 (PST) Received: by 10.82.141.19 with HTTP; Wed, 7 Nov 2007 21:53:22 -0800 (PST) Message-ID: <211709bc0711072153w20990e9u8cb4cac59a0a911c@mail.gmail.com> Date: Thu, 8 Nov 2007 13:53:22 +0800 From: "Tony Wu" To: dev@harmony.apache.org Subject: Re: [classlib]remove the duplicate locale data In-Reply-To: <6e47b64f0711070640r6817b51dv8094baf2a9bd6cdb@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <211709bc0711050033o55158d22mad9dce73f8ad4490@mail.gmail.com> <47305354.6090603@gmail.com> <211709bc0711060623k7a7ed510u4a650adfd9ce914f@mail.gmail.com> <211709bc0711060636w532d2a43nea95f9ea77be345b@mail.gmail.com> <6e47b64f0711070640r6817b51dv8094baf2a9bd6cdb@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org Hi Stepan, this bug fixed at r593024. thanks for pointing out. On 11/7/07, Stepan Mishura wrote: > On 11/6/07, Tony Wu wrote: > > I've committed the patch at r592434. > > the excluded classes are, > > > > tests.api.java.util.CurrencyTest > > tests.api.java.util.FormatterTest > > tests.api.java.util.GregorianCalendarTest > > tests.api.java.util.LocaleTest > > tests.api.java.util.ScannerTest > > > > org.apache.harmony.text.tests.java.text.DecimalFormatSymbolsTest > > org.apache.harmony.text.tests.java.text.NumberFormatTest > > org.apache.harmony.text.tests.java.text.SimpleDateFormatTest > > > > pls kindly let me know if you find any problem, thanks. > > > > According to integrity testing report [1] 4 security tests started to > fail on Windows (DRLVM): > - failure testGeneralizedEncoder > org.apache.harmony.security.tests.asn1.der.DerGeneralizedTimeEDTest > > - failure testUTCEncoder > org.apache.harmony.security.tests.asn1.der.DerUTCTimeEDTest > > - failure test_Decode_Encode > org.apache.harmony.security.tests.asn1.der.GeneralizedTimeTest > > - failure testDecodeEncode > org.apache.harmony.security.tests.asn1.der.UTCTimeTest > > They fail for me too on r592434 but pass on r592433. Could you try to reproduce? > > [1] http://people.apache.org/~varlax/harmony-integrity/ > > Thanks, > Stepan. > > > On 11/6/07, Tony Wu wrote: > > > On 11/6/07, Tim Ellison wrote: > > > > Tony Wu wrote: > > > > > I've raised a JIRA[1] for migrating the dependencies of locale related > > > > > data to icu4j and remove the data in > > > > > luni/src/main/java/org/apache/harmony/luni/internal/locale/. Currently > > > > > I have delegated all the locale related classes to corresponding > > > > > classes in icu4j and successfully removed the dependencies of harmony > > > > > resource bundles. > > > > > > > > Cool -- this is good because it removes the code duplication we have at > > > > present, it shifts the maintenance of the locale data into the right > > > > place (IMHO) that being the ICU project, and gives us the opportunity to > > > > use the ICU tools to customize/refresh/etc the data for Harmony each > > > > time the USA decide to introduce another daylight savings change ;-) > > > > > > exactly. > > > > > > > > > As expected, there are around 20 failures of harmony test. Many of > > > > > them are caused by data difference. I've listed all of them on harmony > > > > > wiki[2] and will raise them to icu soon. > > > > > > > > Ack. I believe that (pretty much) everyone gets the data from the CLDR, > > > > so I would expect any differences to be tests that have out of date > > > > assumptions about the data. > > > > > > Yes, I'll check it based on CLDR. > > > > > > > > > By applying this patch, we can get 4.2 mega bytes decrease in harmony > > > > > source code, including the svn data. > > > > > > > > ooh, say that again! Removing 4.2Mb of redundant source code is excellent. > > > > > > > > > My proposal is to apply the patch on 5061 first and exclude these > > > > > tests which fail on different locale data. Then I'll take follow up > > > > > action to contact icu team and get solution to move them out. > > > > > Otherwise I'm afraid my fix will be outdated for waiting until icu > > > > > team get ready to fix the data. Do you have any objection? > > > > > > > > > > Later, I'll take care of the performance issue of this delegation. > > > > > > > > > > Thanks in advance for your comments > > > > > > > > Sounds like a good plan. > > > > > > > > Regards, > > > > Tim > > > > > > > > > > > > > -- > > > Tony Wu > > > China Software Development Lab, IBM > > > > > > > > > -- > > Tony Wu > > China Software Development Lab, IBM > -- Tony Wu China Software Development Lab, IBM