harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yang Paulex" <paulex.y...@gmail.com>
Subject Re: [luni] Luni experts in China? HARMONY-5092!
Date Wed, 14 Nov 2007 07:09:04 GMT
I've attached a fix for the FileChooser issue(aka, the first one), but I
guess it needs win shell/swing expert to have a look if it's fine.



2007/11/12, Yang Paulex <paulex.yang@gmail.com>:
>
>
>
> 2007/11/12, Jimmy,Jing Lv <firepure@gmail.com>:
> >
> > Hi All,
> >
> >      I've just looked into 5092. The second problem "canRead" seems a
> > bug of file path encode. A simple fix to this is apply a unicode
> > converting in getPlatformIsWriteOnly, use CreateFileW instead of
> > CreateFile, which is similar with Harmony-4794 (Thanks Alexei !)
> >
> >      Another extra finding is that we have a convert method in hyfile.c:
> > void convert_path_to_unicode(struct HyPortLibrary * portLibrary, const
> > char *path,
> >              wchar_t **pathW)
> >     But it is NOT exported, as a result, we have to copy the method
> > into current target helper.c (it does have a convert method mangle,
> > but doesnot work well). Maybe we can re-use it as a util method?
>
>
> I'm always confused by the helpers.c, what's its purpose? seems it
> contains several platform dependent io/network utilities, most of which are
> only used once. On the other hand, there are platform specific
> OSFileSystem<OSType>.c, OSNetWorkSystem<OSType>.c, hyfile.c, etc,
> basically for same purpose.
>
> IMO, the best solution is to encapsulate them into portlib, if for some
> reason not possible, at least make the similar functions locate in same
> source file.
>
>     I've try the test of first problem, but it works well on my
> > desktop. Do I miss something here?
>
>
> It's reproducible on my desktop. Seems swing module has its own
> java.io.File extension named as WinFile, and it overrides the listFiles()
> method for unknown reasons. still looking what's happening there...
>
>     Leo: Are you looking at this?  I'll apply a fix if you dont have time?
> > :)
> >
> > 2007/11/11, Alexei Zakharov <alexei.zakharov@gmail.com>:
> > > Guys,
> > >
> > > Please note, that have already fixed something like this once as part
> > > of HARMONY-4794 ([classlib][luni] unable to create file with Asian
> > > characters in name)
> > >
> > > Thanks,
> > > Alexei
> > >
> > > 2007/11/11, Alexey Petrenko < alexey.a.petrenko@gmail.com>:
> > > > Thank you, Leo!
> > > >
> > > > SY, Alexey
> > > >
> > > > 2007/11/11, Leo Li <liyilei1979@gmail.com>:
> > > > > On 11/8/07, Alexey Petrenko <alexey.a.petrenko@gmail.com> wrote:
> > > > >
> > > > > > Guys,
> > > > > >
> > > > > > our friends from Evermore has posted a new JIRA: HARMONY-5092
> > > > > > This issue is related to file operation on Chinese Windows.
> > > > >
> > > > >
> > > > >
> > > > >    I have tried it on my Windows XP. And it shows that HARMONY
> > really has
> > > > > some problem to treat with chinese words in filename.:)
> > > > >    I will have a look at it.
> > > > >
> > > > >
> > > > >
> > > > > > Do we have luni experts in China who can handle this issue?
:)
> > > > > >
> > > > > > Thanks in advance.
> > > > > >
> > > > > > SY, Alexey
> > > > > >
> > > > > > https://issues.apache.org/jira/browse/HARMONY-5092
> > > > > >
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Leo Li
> > > > > China Software Development Lab, IBM
> > > > >
> > > >
> > >
> >
> >
> > --
> >
> > Best Regards!
> >
> > Jimmy, Jing Lv
> > China Software Development Lab, IBM
> >
>
>
>
> --
> Paulex Yang
> China Software Development Lab
> IBM
>



-- 
Paulex Yang
China Software Development Lab
IBM

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message