harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Petrenko" <alexey.a.petre...@gmail.com>
Subject Re: [windows] is vista explicitly not supported
Date Wed, 14 Nov 2007 13:45:35 GMT
2007/11/14, Gregory Shimansky <gshimansky@apache.org>:
> Alexey Petrenko wrote:
> > Aha, looks so...
> >
> > working_vm\vm\vmcore\src\init\vm_init.cpp
> > === cut ===
> >     if((osvi.dwMajorVersion == 4 && osvi.dwMinorVersion == 0) ||  // NT
4.0
> >        (osvi.dwMajorVersion == 5 && osvi.dwMinorVersion == 0) ||  //
> > Windows 2000
> >        (osvi.dwMajorVersion == 5 && osvi.dwMinorVersion == 1) ||  // Windows
XP
> >        (osvi.dwMajorVersion == 5 && osvi.dwMinorVersion == 2)) {  //
> > Windows.NET
> >             return JNI_OK;
> >     }
> >     printf("Windows %d.%d is not supported\n", osvi.dwMajorVersion,
> > osvi.dwMinorVersion);
> >     return JNI_ERR;
> > === cut ===
> >
> > Do we really have some code which prevents us from running on Windows
> > version higher then 5? We can't we just check min version?
> >
> > Nathan, could you please remove this check and test what happens? :)
>
> I think this code was written before Vista existed to make sure the OS
> version is not too old. It could be changed to handle more modern
> versions automatically.
Yes, I think we could change it to
=== cut ===
if(osvi.dwMajorVersion >= 4)
=== cut ===

SY, Alexey

Mime
View raw message