harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jimmy,Jing Lv" <firep...@gmail.com>
Subject Re: [general] Commit messages (was Re: svn commit: r595625 - in /harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java: net/URLConnection.java util/Date.java)
Date Mon, 19 Nov 2007 02:36:30 GMT
Oops, sorry for the neglectfulness, I'll fix them soon.
Thanks for your advice Mark :)

2007/11/19, Mark Hindess <mark.hindess@googlemail.com>:
>
> Apologies for moaning again but I promise to stop moaning when every
> gets it right . . .
>
> On 16 November 2007 at 11:04, tonywu@apache.org wrote:
> > Author: tonywu
> > Date: Fri Nov 16 03:04:25 2007
> > New Revision: 595625
> >
> > URL: http://svn.apache.org/viewvc?rev=595625&view=rev
> > Log:
> > Apply patch for Harmony-5112 ([classlib][luni][EUT] r592434 caused regression
> >  in EUT3.3)
> > [SNIP]
>
> The case of 'HARMONY-5112' is important.  If you get it right (ALL UPPER
> CASE) then it gets linked in to the "Subversion commits" tab in the
> JIRA.  This commit will not be listed as the case is incorrect.
>
> and on 18 November 2007 at 15:19, lvjing@apache.org wrote:
> >
> > Author: lvjing
> > Date: Sun Nov 18 07:19:54 2007
> > New Revision: 596091
> >
> > URL: http://svn.apache.org/viewvc?rev=596091&view=rev
> > Log: Apply for Harmony-5132
>
> *sigh* ... this is a useless log message.  Please read the "Commit
> messages" section of:
>
>   http://wiki.apache.org/harmony/NewCommitter
>
> If this wiki page is not clear, please update it.
>
> I've also checked in an update to this commit because two added files
> were missing the license header.
>
> Regards,
>  Mark.
>
>
>


-- 

Best Regards!

Jimmy, Jing Lv
China Software Development Lab, IBM

Mime
View raw message