harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rana Dasgupta" <rdasg...@gmail.com>
Subject Re: [drlvm][GC]Bad Pointer during GC v5 shutdown sequence
Date Tue, 13 Nov 2007 17:05:47 GMT
Yes, I will try to put in an update today.

On 11/12/07, Xiao-Feng Li <xiaofeng.li@gmail.com> wrote:
>
> The patch is great. Some improvement is necessary before committing.
> Please check the comments I put in the JIRA issue.
>
> Thanks,
> xiaofeng
>
> On 11/12/07, Ilya Leviev <ilya.leviev@gmail.com> wrote:
> > Rana,
> >
> > Thank you for evaluation and a quick patch. It seems that the patch
> > you have prepared solves the problem with invalid pointer.
> >
> > To check that the patch fixes the memory leak I've applied your patch
> > and rerun BoundsChecker. The tool detected no leek related to this
> > issue with your patch applied. Thank you again for the great job: your
> > patch decreased leaks by 256 MB!
> >
> > Best regards,
> > Ilya.
> >
> >
> > On 11/10/07, Rana Dasgupta <rdasgupt@gmail.com> wrote:
> > > Illya,
> > > Yes, it's possible that there could be a leak. An assert added to
> > > vm_unmap_mem() does show that the VirtualFree fails. The pointer
> parameter
> > > etc. passed to the function are invalid because the sections of the
> heap (
> > > nos, mos etc. ) have already been freed with STD_FREE.
> > >  The root cause is that for VirtualFree() to successfully release on
> > > Windows, it needs to be called from the exact VirtualAlloc allocation
> base.
> > > I have attached a quick fix in
> > > H5105<https://issues.apache.org/jira/browse/HARMONY-5105>
> > > which you can try. Xiao Feng needs to look at it.
> > >
> > > Rana
> > >
> >
>
>
> --
> http://xiao-feng.blogspot.com
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message