harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tony Wu" <wuyue...@gmail.com>
Subject Re: [classlib][luni][EUT] regression caused by r592434
Date Fri, 16 Nov 2007 11:13:58 GMT
Thanks fro your help.

Finally I have successfully reproduced it on my ubuntu and provided
another fix on JIRA. It has been committed at r595625.

This patch utilizes the Date.parse(String) by adding a bit of code to
handle the minute part of the time offset.

On 11/15/07, Vladimir Beliaev <vladimir.k.beliaev@gmail.com> wrote:
> Hello, Tony,
>
> I've tested it - unfortunately the issue is kept actual. The same set of
> tests ended with errors, now with stack ended in Date class:
>
>
> org.eclipse.update.tests.regularInstall.TestSpaceInInstall.testSpaceInHTTPURL
>   null
>   java.lang.IllegalArgumentException
>     at java.util.Date.parse(Date.java:459)
>     at java.net.URLConnection.getHeaderFieldDate(URLConnection.java:521)
>     at java.net.HttpURLConnection.getHeaderFieldDate(HttpURLConnection.java
> :467)
>     <skipped>
>
> I'm sorry for not preparing a stand a long test case - it always time
> consuming process and from my expirience a regression fixer gets the idea of
> the patch w/o such a test and it takes less time then to prepare this test.
>
> Thanks
> Vladimir Beliaev
>
> 2007/11/15, Tony Wu <wuyuehao@gmail.com>:
> >
> > Hi Vladimir,
> > I guess that this IAE is thrown because the Util.parseDate can not
> > handle the pattern which contains "+".  I have provided a patch on the
> > JIRA, would you please try it.
> >
> > I'm still downloading the eclipse test suite to verify it but I'm
> > afraid it will take several hours since the network here is overload.
> >
> > On 11/14/07, Tony Wu <wuyuehao@gmail.com> wrote:
> > > sure, I will find the problem asap. Thanks for the report.
> > >
> > > On 11/14/07, Vladimir Beliaev <vladimir.k.beliaev@gmail.com> wrote:
> > > > Hello, Tony,
> > > >
> > > > could you care about recently filed
> > > > https://issues.apache.org/jira/browse/HARMONY-5112? (either fix
> > regression
> > > > or revert your patch)?
> > > >
> > > > This is a regression introduced by r592434 commit fixing HARMONY-5061
> > (it
> > > > has taken time double check the regression and detect the guilty
> > commit, so
> > > > I reported the regression just yesterday).
> > > >
> > > > Please see the EUT report at:
> > > >
> > http://people.apache.org/~smishura/r593024/Windows_x86/eut33/results/html/org.eclipse.update.tests.core_win32.win32.x86.html
> > > >
> > > > - all tests are failed with the same exception:
> > > > java.lang.IllegalArgumentException
> > > >    at org.apache.harmony.luni.util.Util.parseDate(Util.java:136)
> > > >    at java.net.URLConnection.getHeaderFieldDate(URLConnection.java
> > :519)
> > > >    at java.net.HttpURLConnection.getHeaderFieldDate(
> > HttpURLConnection.java
> > > > :467)
> > > >
> > > > Thanks
> > > > Vladimir
> > > >
> > > >
> > > > -----Original Message-----
> > > > From: tonywu@apache.org [mailto:tonywu@apache.org]
> > > > Sent: Tuesday, November 06, 2007 5:21 PM
> > > > To: commits@harmony.apache.org
> > > > Subject: svn commit: r592434 [1/2] - in
> > > > /harmony/enhanced/classlib/trunk/modules: luni/make/
> > > > luni/src/main/java/java/util/
> > > > luni/src/main/java/org/apache/harmony/luni/internal/locale/
> > > > luni/src/test/api/common/tests/api/java/util/ text/make/
> > > > text/src/main/java/ja...
> > > >
> > > >
> > > >
> > > > Author: tonywu
> > > >
> > > > Date: Tue Nov  6 06:21:10 2007
> > > >
> > > > New Revision: 592434
> > > >
> > > >
> > > >
> > > > URL: http://svn.apache.org/viewvc?rev=592434&view=rev
> > > >
> > > > Log:
> > > > Apply patch Harmony-5061 which removes the duplicate locale data
> > > >
> > > > <skipped...>
> > > >
> > >
> > >
> > > --
> > > Tony Wu
> > > China Software Development Lab, IBM
> >
>


-- 
Tony Wu
China Software Development Lab, IBM

Mime
View raw message