harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tony Wu" <wuyue...@gmail.com>
Subject Re: [classlib][icu] there is performance degradation after ICU-related commits
Date Wed, 14 Nov 2007 15:40:36 GMT
I have mentioned that the delegation will do harm to the performance.
There must be many similar places in Format and its sub classes.

I've been thinking about that is it possible to ask icu team to
contribute their code to harmony directly. Basically the icu code is
writtern against the java api, and the only reason for which we have
to do the delegation is that the package is not "java.*". I did a
quick look on the license of icu and my understanding is that anyone
can make use of its code freely but I need further confirmation since
I'm not the lawyer.

On 11/14/07, Aleksey Shipilev <aleksey.shipilev@gmail.com> wrote:
> Hi all,
>
> I have investigated this problem and found that guilty method is
>  SimpleTimeZone/useDaylightTime(), changed by this chunk:
>
> Index: modules/luni/src/main/java/java/util/SimpleTimeZone.java
> ===================================================================
> --- modules/luni/src/main/java/java/util/SimpleTimeZone.java (revision 593468)
> +++ modules/luni/src/main/java/java/util/SimpleTimeZone.java (revision 593469)
> @@ -837,7 +738,7 @@
>  */
>  @Override
>     public boolean useDaylightTime() {
> - return useDaylight;
> + return icuTZ.useDaylightTime();
>  }
>
> Please see JIRA for details.
>
> Thanks,
> Aleksey,
> ESSD, Intel
>
> On Nov 14, 2007 2:36 PM, Rustem Rafikov <r.v.rafikov@gmail.com> wrote:
> > Hi All,
> > We experienced noticeable performance degradation after one of the
> > ICU-related commits.
> > There were: 1. r592434 and 2. r593469
> > After the second one jbb2005's scores decreased on 15-20%.
> >
> > I filled JIRA [1] , please look into.
> >
> > [1] http://issues.apache.org/jira/browse/HARMONY-5122,
> >
> >
> > --
> > Thanks,
> > Rustem
> >
>


-- 
Tony Wu
China Software Development Lab, IBM

Mime
View raw message