harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tony Wu" <wuyue...@gmail.com>
Subject Re: [classlib]remove the duplicate locale data
Date Tue, 06 Nov 2007 07:15:53 GMT
On 11/6/07, Leo Li <liyilei1979@gmail.com> wrote:
> On 11/6/07, Tony Wu <wuyuehao@gmail.com> wrote:
> >
> > On 11/5/07, Oliver Deakin <oliver.deakin@googlemail.com> wrote:
> > > Tony Wu wrote:
> > > > Hi all,
> > > >
> > > > I've raised a JIRA[1] for migrating the dependencies of locale related
> > > > data to icu4j and remove the data in
> > > > luni/src/main/java/org/apache/harmony/luni/internal/locale/. Currently
> > > > I have delegated all the locale related classes to corresponding
> > > > classes in icu4j and successfully removed the dependencies of harmony
> > > > resource bundles.
> > > >
> > >
> > > Good work Tony!
> > >
> > > > As expected, there are around 20 failures of harmony test. Many of
> > > > them are caused by data difference. I've listed all of them on harmony
> > > > wiki[2] and will raise them to icu soon.
> > > >
> > >
> > > Thanks Tony. When fixes for these issues get into the icu codebase we
> > > can rebuild the icu source and update the jar in our repository.
> >
> > yes, we can move the excluded test out after that.
>
>
>   Maybe first we must assure these tests can pass on RI.:)

Yes, this is a good point. Actually there are a few tests failing on
ri too, I've fixed some of them and others need further investigation.
>
> >
> > > > By applying this patch, we can get 4.2 mega bytes decrease in harmony
> > > > source code, including the svn data.
> > > >
> > >
> > > Great!
> > >
> > > Regards,
> > > Oliver
> > >
> > > > My proposal is to apply the patch on 5061 first and exclude these
> > > > tests which fail on different locale data. Then I'll take follow up
> > > > action to contact icu team and get solution to move them out.
> > > > Otherwise I'm afraid my fix will be outdated for waiting until icu
> > > > team get ready to fix the data. Do you have any objection?
> > > >
> > > > Later, I'll take care of the performance issue of this delegation.
> > > >
> > > > Thanks in advance for your comments
> > > >
> > > > [1]
> > > > https://issues.apache.org/jira/browse/HARMONY-5061
> > > >
> > > > [2]
> > > > http://wiki.apache.org/harmony/MigrateToICU
> > > >
> > > >
> > > >
> > >
> > > --
> > > Oliver Deakin
> > > Unless stated otherwise above:
> > > IBM United Kingdom Limited - Registered in England and Wales with number
> > 741598.
> > > Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6
> > 3AU
> > >
> > >
> >
> >
> > --
> > Tony Wu
> > China Software Development Lab, IBM
> >
>
>
>
> --
> Leo Li
> China Software Development Lab, IBM
>


-- 
Tony Wu
China Software Development Lab, IBM

Mime
View raw message