Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: neutral (athena.apache.org: 195.212.29.135 is neither permitted
 nor denied by domain of mark.hindess@googlemail.com)
Message-Id: <200710170532.l9H5W1WT030839@d06av01.portsmouth.uk.ibm.com>
In-reply-to: <c30d70960710161442g7438cd4dj93bd825ba981eb40@mail.gmail.com> 
References: <20071016143953.17E8E1A983A@eris.apache.org>
 <c30d70960710161442g7438cd4dj93bd825ba981eb40@mail.gmail.com>
Comments: In-reply-to "Alexei Fedotov" <alexei.fedotov@gmail.com>
   message dated "Wed, 17 Oct 2007 01:42:09 +0400."
From: Mark Hindess <mark.hindess@googlemail.com>
To: dev@harmony.apache.org
Subject: Re: svn commit: r585156 -
 /harmony/enhanced/classlib/trunk/modules/portlib/src/main/native/port/shared/hyport.c 
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Date: Wed, 17 Oct 2007 06:31:52 +0100


Alexei,

I've reverted the patch in r585384.  However, please can you try 
changing the problem line to:

  portLib->mem_free_memory (portLib, (void*)pathSet);

since I think that should also fix it - and still remove the
warning (not treated as an error [yet]) on gcc 4.2.

-Mark.
  
On 17 October 2007 at 1:42, "Alexei Fedotov" <alexei.fedotov@gmail.com> wrote:
> Hello Mark,
> 
> It seems that this commit produce the following error in my
> environment (Windows):
> 
>      [java]      [exec] ..\shared\hyport.c(620) : error C2220: warning
> treated as error - no object file generated
>      [java]      [exec] ..\shared\hyport.c(620) : warning C4090:
> 'function' : different 'const' qualifiers
> 
> for the line:
>     portLib->mem_free_memory (portLib, pathSet);
> 
> I believe the easiest way to fix this is to revert the patch.
> Thanks!
> 
> 
> 
> On 10/16/07, hindessm@apache.org <hindessm@apache.org> wrote:
> > Author: hindessm
> > Date: Tue Oct 16 07:39:44 2007
> > New Revision: 585156
> >
> > URL: http://svn.apache.org/viewvc?rev=585156&view=rev
> > Log:
> > Fix compiler warning.
> >
> > Modified:
> >     harmony/enhanced/classlib/trunk/modules/portlib/src/main/native/port/sh
> ared/hyport.c
> >
> > Modified: harmony/enhanced/classlib/trunk/modules/portlib/src/main/native/p
> ort/shared/hyport.c
> > URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/p
> ortlib/src/main/native/port/shared/hyport.c?rev=585156&r1=585155&r2=585156&vi
> ew=diff
> > ===========================================================================
> ===
> > --- harmony/enhanced/classlib/trunk/modules/portlib/src/main/native/port/sh
> ared/hyport.c (original)
> > +++ harmony/enhanced/classlib/trunk/modules/portlib/src/main/native/port/sh
> ared/hyport.c Tue Oct 16 07:39:44 2007
> > @@ -590,7 +590,8 @@
> >  {
> >    char *endPathPtr = NULL;
> >    char *launcherName = NULL;
> > -  char **pathSet = portLib->mem_allocate_memory (portLib, sizeof(char*)*2)
> ;
> > +  const char **pathSet =
> > +          portLib->mem_allocate_memory (portLib, sizeof(char*)*2);
> >    char *vmPath = NULL;
> >
> >    hysysinfo_get_executable_name (portLib, NULL, &launcherName);
> >
> >
> >
> 
> 
> -- 
> With best regards,
> Alexei,
> ESSD, Intel
>