harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov" <alexey.v.varla...@gmail.com>
Subject Re: [drlvm] Removing empty files?
Date Fri, 26 Oct 2007 04:54:08 GMT
Dropped them at revision: 588523, thanks.

--
Alexey

2007/10/26, Gregory Shimansky <gshimansky@apache.org>:
> Mark Hindess wrote:
> > Any reason why we need to keep the following empty files in drlvm:
> >
> >   vm/vmcore/src/kernel_classes/native/java_lang_VMStart.cpp
> >     (last changed by geirm r454411 as part of HARMONY-1582)
> >
> >   vm/jitrino/src/codegenerator/CodeGenIntfc.cpp
> >   vm/jitrino/src/dynopt/EdgeProfiler.h
> >   vm/jitrino/src/shared/Exceptions.h
> >     (last changed by varlax r525110 as part of HARMONY-3511)
>
> I think that's because patch command doesn't delete files. It just makes
> them of zero length. I had to "svn remove" them by hands when I applied
> a patch that removes a file. Most likely they were missed for deletion
> and should just be removed.
>
> --
> Gregory
>
>

Mime
View raw message