harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dmitriy Matveev" <matveev.dmit...@gmail.com>
Subject Re: [classlib] Re: svn commit: r584159 - in /harmony/enhanced/classlib/trunk/modules/awt/src/main: java/unix/org/apache/harmony/awt/gl/font/ java/unix/org/apache/harmony/awt/gl/linux/ native/linuxfont/unix/ native/linuxfont/unix/include/
Date Wed, 17 Oct 2007 14:21:28 GMT
Actually I enabled antialiasing on linux about one year ago and this patch
was based on code of that period.
I have not noticed that we use another kind of exceptions now.

Thx,
Dmitriy.

2007/10/17, Alexei Zakharov <alexei.zakharov@gmail.com>:
>
> BTW, Dmitriy, why have you decided to use newNullPointerException()?
>
> Alexei
>
> 2007/10/17, Dmitriy Matveev <matveev.dmitriy@gmail.com>:
> > Thanks, Mark,
> > thanks Alexey.
> >
> > I wish to pay your attention, that this patch is only a part of
> > antialiasing's enabling.
> > We still cann't draw antialiased text on buffered image, which is the
> > widespread way for drawing text.
> >
> > Mark, I didn't have any errors while building and running tests too.
> >
> > Thx,
> > Dmitriy.
> >
> > 2007/10/17, Mark Hindess <mark.hindess@googlemail.com>:
> > >
> > >
> > > On 17 October 2007 at 14:02, "Alexei Zakharov" <
> alexei.zakharov@gmail.com>
> > > wrote:
> > > > Nice, thanks a lot Mark. The most interesting thing is that I
> haven't
> > > > seen any error messages neither while running a test from
> HARMONY-4562
> > > > nor while standard commit testing that includes Swing and AWT unit
> > > > tests. Most likely the difference was in the fact I was using DRLVM
> > > > and you probably use J9. AFAIK DRLVM uses APR's apr_dso_load to load
> > > > dll's that to all appearance just silently ignores unresolved
> symbols.
> > > > So I was enjoying nice Linux fonts in spite of the fact that the
> > > > reference to newNullPointerException was not resolved. :)
> > >
> > > Yes.  That makes sense[0].  I had just assumed you hadn't updated your
> > > workspace in a rather long time. ;-)
> > >
> > > Regards,
> > > Mark.
> > >
> > > [0] I can see why this behaviour might be useful if you had circular
> > >     references but I'm not convinced it is all that helpful for our
> > >     environment - I prefer to see the errors immediately.
> > >
> > > > 2007/10/16, Mark Hindess <mark.hindess@googlemail.com>:
> > > > >
> > > > > Alexei,
> > > > >
> > > > > The change to LinuxNativeFont.cpp introduces to calls to
> > > > > newNullPointerException.  There were other references to this
> function
> > > > > in the originally contributed version of this file but in order to
> be
> > > > > consistent with the rest of the native code, I replaced them in
> > > commit:
> > > > >
> > > > >   r423405 | hindessm | 2006-07-19 09:51:27 +0100 (Wed, 19 Jul
> 2006) |
> > > 1 lin
> > > > e
> > > > >
> > > > >   Change awt natives to use exception functions from luni common
> > > library.
> > > > >
> > > > > I can't understand how this code would work for you.  I get
> undefined
> > > > > symbol errors when the dlopen call tries to load the linuxfont
> dll.
> > > > >
> > > > > I've checked in a change, r585221, to replace these function calls
> > > with
> > > > > calls to the replacement current equivalent function,
> > > throwNPException.
> > > > >
> > > > > The linux fonts look much better for me now.  Nice work Dmitriy.
> > > > >
> > > > > Regards,
> > > > >  Mark.
> > > > >
> > > > > On 12 October 2007 at 13:11, ayza@apache.org wrote:
> > > > > > Author: ayza
> > > > > > Date: Fri Oct 12 06:10:33 2007
> > > > > > New Revision: 584159
> > > > > >
> > > > > > URL: http://svn.apache.org/viewvc?rev=584159&view=rev
> > > > > > Log:
> > > > > > Support for antialiasing for Unix fonts was added. See
> HARMONY-4562
> > > ([cla
> > > > ssli
> > > > > > b][awt] Antialliasing is not implemented on Linux)
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message