Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (herse.apache.org: domain of mloenko@gmail.com designates
 66.249.92.175 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=jLkxhsj8Umhz1kvdcZIyf0IdBL9xmRSk0caWBwSiiWyHrxWjE71l1I5Ac8XhsVzjAseHT7wKA0oEv9eTyk/2P7ofP+Jr15xpTOXMX870gemBlZMc+Bj+Q6T0q4rem1tDkIG6uPXSGUBZ0f8yhLlvDe/Ye+xvh6EXKn729nB6VsU=
Message-ID: <906dd82e0707100329h2146fd06i27ed7369a28c761e@mail.gmail.com>
Date: Tue, 10 Jul 2007 17:29:06 +0700
From: "Mikhail Loenko" <mloenko@gmail.com>
To: dev@harmony.apache.org
Subject: Re: [vote] HARMONY-4266 - performance regression testing
 infrastructure
In-Reply-To: <4692B2EE.4040609@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <906dd82e0707060501m23c4ea33v974f1ad7f853151e@mail.gmail.com>
	 <4692B2EE.4040609@gmail.com>

2007/7/10, Tim Ellison <t.p.ellison@gmail.com>:
> Mikhail Loenko wrote:
> > We now have all requisite paperwork in place for
> > http://issues.apache.org/jira/browse/HARMONY-4266, so let's vote to accept:
> >
> > [ ] +1 Accept this contribution
> > [ ] -1 Reject because...
> >
> > As usual, 3 days unless someone complains they need more time.
>
> I'd like a bit more time to look through the code please.
>
> A minor observation is that the ASF block comments in each file need
> updating to the new format [1] (without the Copyright line).
>
> One of the attached patches [2] has a copy of
> PRTI/setup/src/PRTIJUnitTestRunner/JUnitTask.java probably by mistake,
> as I don't think it has been written by the contributor.
>
> Nothing fatal, but I'd like to spend a bit more time (a couple of days)
> looking through it.

Sure,

Thanks,
Mikhail

>
> [1] http://www.apache.org/legal/src-headers.html
> [2]
> http://issues.apache.org/jira/secure/attachment/12361160/prti-classlib.patch
>
> Thanks,
> Tim
>