From dev-return-28299-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Thu Jul 05 03:28:55 2007 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 47608 invoked from network); 5 Jul 2007 03:28:54 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 5 Jul 2007 03:28:54 -0000 Received: (qmail 4913 invoked by uid 500); 5 Jul 2007 03:28:55 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 4894 invoked by uid 500); 5 Jul 2007 03:28:55 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 4885 invoked by uid 99); 5 Jul 2007 03:28:55 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jul 2007 20:28:55 -0700 X-ASF-Spam-Status: No, hits=2.3 required=10.0 tests=HTML_MESSAGE,MAILTO_TO_SPAM_ADDR,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of smallsmallorgan@gmail.com designates 209.85.146.180 as permitted sender) Received: from [209.85.146.180] (HELO wa-out-1112.google.com) (209.85.146.180) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Jul 2007 20:28:49 -0700 Received: by wa-out-1112.google.com with SMTP id k22so3509500waf for ; Wed, 04 Jul 2007 20:28:29 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=oiiRW4J5m4x2VhyFTXCllbVdZMxTOkrBgZRUqC5M3xR3LCoo1q9esM1fPpfItRjZsX/KfDGDnB1WNZKppi7NHIaRG4LAuVRwVmbtfLdxc8EXYU0Zn+LObHkHCPdNZBaN+w/0RQWeYZ0Vciu370EAx9KRhI22kbkQD5YPtPph/Yw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=XRGhpVZiqLhdz3v9q0ebiWEARnnJGqm4JfEfTejLNCZdSyx6FjUoGgWU1wcnHLXKHR3SMHGrIR24zEOd/OUCVSMndk8K18JaEBOwkftcf5P8L5M1UwQxP1/Thh2sfxP/iq9wvljfhtHZxiOxSCqPxGT58wi1sCet8OPuHWoTCKY= Received: by 10.114.103.1 with SMTP id a1mr7761596wac.1183606108886; Wed, 04 Jul 2007 20:28:28 -0700 (PDT) Received: by 10.114.109.11 with HTTP; Wed, 4 Jul 2007 20:28:28 -0700 (PDT) Message-ID: <473c46620707042028r4e2b46e2n81db27b8fc276372@mail.gmail.com> Date: Thu, 5 Jul 2007 11:28:28 +0800 From: "Spark Shen" To: dev@harmony.apache.org Subject: Re: [classlib][beans] Current java6 bean implementation does not persist some class properly [was: There are some JDK 6 feature not implemented] In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_144921_14734057.1183606108852" References: <473c46620707030357u38241ac8kc4d544cc4b9573cb@mail.gmail.com> <211709bc0707030542t668630f2o2b7eb9c375b1b81b@mail.gmail.com> <2c9597b90707040819x1e911e0eu1a2e9ae3af38b663@mail.gmail.com> <473c46620707041931u3ddee6ffvb4a99e4791ec4b07@mail.gmail.com> <473c46620707042017j5ddd258blc99e9e5d6251c27d@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_144921_14734057.1183606108852 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline 2007/7/5, Yang Paulex : > > 2007/7/5, Spark Shen : > > > > 2007/7/5, Leo Li : > > > > > > Agree. > > > More testcases shall be added and maybe we need an estimation and a > plan > > > before we start. Since the spec of beans module is so unclear that it > > will > > > give us benefits if we can grasp the global image of the problem and > > where > > > to refractor and what function shall be added. > > > > > > Hmm, agree. > > I am now working on this issues for several days, and the 2 big problems > > related to beans module are: > > > > 1. Some test cases fails on RI while some others fail on Harmony. > > > I had some similar observations, IMO, we need to make the test pass on RI > at > first(except some non-bug difference cases). And I also found that the > test > results are different on RI 5 and 6, probably there are some bug fixing in > RI 6, so the question is: which version we should follow if this is the > case? > > 2. PeresistenceDelegate does not persist object properly, for example > > current implementation does not persist collection, awt.Choice etc. > > > Would you please provide some tests and raise jira on these issues? Sure, and I have already reported 3 JIRAs: https://issues.apache.org/jira/browse/HARMONY-4321 https://issues.apache.org/jira/browse/HARMONY-4326 https://issues.apache.org/jira/browse/HARMONY-4327 Is some one else also interested, or could provide more information on this > > module? > > > Sure, I also have interest to improve beans module. Thank you. I will make a wiki page for beans module, and we can record our progress there. On 7/5/07, Yang Paulex wrote: > > > > > > > > 2007/7/5, Spark Shen : > > > > > > > > > > 2007/7/5, Yang Paulex : > > > > > > > > > > > > 2007/7/4, Alexei Zakharov : > > > > > > > > > > > > > > Spark Chen wrote: > > > > > > > > > If no objection, I will go to implement those missing > > > > persistence > > > > > > > > > functionality. > > > > > > > > > > > > > > FYI we already have number of persistence delegates classes > > > located > > > > in > > > > > > > org.apache.harmony.beans package, and FieldPersistenceDelegate > > is > > > > one > > > > > > > of them. > > > > > > > > > > > > > > > I agree to utilize existing implementation. But there are still > > others > > > > > missing. For example, java.util.Collection and its subclasses[1]. > > > > > > > > > > [1]http://issues.apache.org/jira/browse/HARMONY-4327 > > > > > > > > > > It contains the algorithm that is very close to one you've > > > > > > > implemented in the patch for HARMONY-4321. So I don't think we > > > > should > > > > > > > add new FieldPersistenceDelegate, let's fix the existing one > > > instead > > > > > > > (if it needs fixing). BTW, we also have a special folder > > > > > > > (src/test/java-internal/org/apache/harmony/beans) where tests > > for > > > > > > > persistence delegates are located. Shouldn't we create > something > > > > like > > > > > > > FieldPersistenceDelegateTest there? > > > > > > > > > > > > > > > > > > Seems the tests in > src/test/java-internal/org/apache/harmony/beans > > > are > > > > > > implementation tests, all of which fail on RI with message like > " > > > > > > java.lang.NoClassDefFoundError: > > > > > > org/apache/harmony/beans/ArrayPersistenceDelegate ". But I think > > the > > > > > > persistent delegate mechanism are very similar with > serialization, > > > on > > > > > > which > > > > > > we need to be compatible with other Java SE implementation, so > it > > > > makes > > > > > > sense to make them the API tests which pass on RI. Did I miss > > > > something? > > > > > > > > > > > > > > > I agree to regard these test cases as API tests. And then these > > > > > persistenceDelegate implementations better be placed at > > > > > src/main/java/java/beans corresponding to test case layout. > > > > > > > > > > > > IMO, test case layout and implementation class layout are different > > > > thing. > > > > What I meant is the test cases may need to be written against API > > > factory > > > > method instead of construct implementation classes directly via > > > > implementation specific constructor/class, and the compatibility > tests > > > > like > > > > serialization tests are needed. I have no preference in where the > > > > implementation classes locate. :) > > > > > > > > Thanks, > > > > > > > > > > > > > > 2007/7/3, Tony Wu : > > > > > > > > On 7/3/07, Spark Shen wrote: > > > > > > > > > I find beans.XMLEncoder does not persist > > > > > > java.lang.reflect.Fieldproperly. > > > > > > > > > And I suspect there are more classes not properly handled. > > > > > > > > > > > > > > > > > > > > > > > > > Yes, I think so. > > > > > > > > > I have reported a JIRA: > > > > > > > > > https://issues.apache.org/jira/browse/HARMONY-4321 > > > > > > > > > > > > > > > > > > If no objection, I will go to implement those missing > > > > persistence > > > > > > > > > functionality. > > > > > > > > > > > > > > > > > > > > > > > > > please go head:) > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Alexei Zakharov, > > > > > > > Intel ESSD > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Paulex Yang > > > > > > China Software Development laboratory > > > > > > IBM > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > Spark Shen > > > > > China Software Development Lab, IBM > > > > > > > > > > > > > > > > > > > > > -- > > > > Paulex Yang > > > > China Software Development laboratory > > > > IBM > > > > > > > > > > > > > > > > -- > > > Leo Li > > > China Software Development Lab, IBM > > > > > > > > > > > -- > > Spark Shen > > China Software Development Lab, IBM > > > > > > -- > Paulex Yang > China Software Development laboratory > IBM > -- Spark Shen China Software Development Lab, IBM ------=_Part_144921_14734057.1183606108852--