harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Leo Li" <liyilei1...@gmail.com>
Subject Re: svn commit: r561285 - in /harmony/enhanced/classlib/trunk/modules/luni/src: main/java/java/util/Stack.java test/api/common/tests/api/java/util/StackTest.java
Date Tue, 31 Jul 2007 11:45:36 GMT
On 7/31/07, Tim Ellison <t.p.ellison@gmail.com> wrote:
>
> leoli@apache.org wrote:
> > Modified:
> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Stack.java
> > URL:
> http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Stack.java?view=diff&rev=561285&r1=561284&r2=561285
> >
> ==============================================================================
> > ---
> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Stack.java
> (original)
> > +++
> harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/util/Stack.java
> Tue Jul 31 02:39:44 2007
> > @@ -39,7 +39,7 @@
> >        *
> >        * @return true if the stack is empty, false otherwise
> >        */
> > -     public boolean empty() {
> > +     public synchronized boolean empty() {
> >               return elementCount == 0;
> >       }
>
> Why make this synchronized?


   The synchronize on empty() method seems unnecessary.
   I have removed it at r561301. Is it all right, Spark?

Regards,
> Tim
>



-- 
Leo Li
China Software Development Lab, IBM

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message