harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tim Ellison <t.p.elli...@gmail.com>
Subject Re: [vote] HARMONY-4266 - performance regression testing infrastructure
Date Wed, 11 Jul 2007 11:55:08 GMT
Mikhail Loenko wrote:
> 2007/7/10, Tim Ellison <t.p.ellison@gmail.com>:
>> Mikhail Loenko wrote:
>> > We now have all requisite paperwork in place for
>> > http://issues.apache.org/jira/browse/HARMONY-4266, so let's vote to
>> accept:
>> >
>> > [ ] +1 Accept this contribution
>> > [ ] -1 Reject because...
>> >
>> > As usual, 3 days unless someone complains they need more time.
>>
>> I'd like a bit more time to look through the code please.
>>
>> A minor observation is that the ASF block comments in each file need
>> updating to the new format [1] (without the Copyright line).
>>
>> One of the attached patches [2] has a copy of
>> PRTI/setup/src/PRTIJUnitTestRunner/JUnitTask.java probably by mistake,
>> as I don't think it has been written by the contributor.
>>
>> Nothing fatal, but I'd like to spend a bit more time (a couple of days)
>> looking through it.
> 
> Sure,


What are we voting on?! that JIRA's attachments seem to keep changing!

I suggest we focus on the original contribution that we have received
the paperwork for, and that new work is attached to a new JIRA issue.

Regards,
Tim

Mime
View raw message