Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (herse.apache.org: domain of mloenko@gmail.com designates
 66.249.92.169 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=A1PNUyyNKIPup5OUxufwmEtPSweadjf8sNCA25TvLIuhH5iZx/QEzUXhqfdAoqtkoEFGerGyVBvryv6Q34PftYHfNmrFg5DU5cC+lCU4Zz6SS565dUOox4mb5D0JwsknhQBkEtxJvxGlF7W/A/zbf00w3HsdKJ9uMJVTmZ9Ebsw=
Message-ID: <906dd82e0706262247q1a625f47xf711d9f6112dd0ed@mail.gmail.com>
Date: Wed, 27 Jun 2007 09:47:04 +0400
From: "Mikhail Loenko" <mloenko@gmail.com>
To: dev@harmony.apache.org
Subject: Re: [classlib][build] difference between classlib 'debug' and
 'release' build modes
In-Reply-To: <7273946b0706261948r7a878d21x61b5574bd92e8165@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <7273946b0706260508me281853pf1d4b15f9890f1d8@mail.gmail.com>
	 <46810DE3.6090208@gmail.com>
	 <2c9597b90706260811s3ee8466djd6464d5168d97806@mail.gmail.com>
	 <2c9597b90706260902p4ea554d2gf42d11596db292a8@mail.gmail.com>
	 <2c9597b90706261057o70549d27l28c50b34e920978f@mail.gmail.com>
	 <46817FDE.10800@gmail.com>
	 <6e47b64f0706261927p1573eaf6gb2c29d8fe3621ad7@mail.gmail.com>
	 <7273946b0706261948r7a878d21x61b5574bd92e8165@mail.gmail.com>

2007/6/27, Vladimir Ivanov <ivavladimir@gmail.com>:
> On 6/27/07, Stepan Mishura <stepan.mishura@gmail.com> wrote:
> > On 6/27/07, Tim Ellison <t.p.ellison@gmail.com> wrote:
> > > Alexei Zakharov wrote:
> > > > The reason of these failures lies in fdlibm indeed. Yes, it was
> > > > tweaked to use "-O0" but there was a typo in this tweak and it does
> > > > not affect the compilation. As a result fdlibm was compiled with "-O1"
> > > > as all other natives. I has created HARMONY-4287 and attached a patch
> > > > for this issue. The patch itself is trivial:
> > > <snip>
> > > >
> > > > So I suggest to commit it and include into our M2 build. Waiting for
> > > > other committer's vote...
> > >
> > > A dumb question but does it fix the problem?
> >
> > I've run classlib tests with the patch applied and these failures disappeared.
> >
> > > It's been like that since
> > > r483045 (i.e. before M1).  I'm surprised we didn't find it when testing
> > > that.
> >
> > I'm afraid but it looks like in M1 we relied on CC status - I created
> > snapshots when all CCs were up (this includes classlib tests). And CC
> > runs classlib tests on debug build so they passed.
> >
>
> > BTW, this is a good example for obtaining all milestone's results with
> > the snapshot build.
>
> Actually, this is a good example to show that we should test both:
> release and debug builds while results can be different :)

I think we should create a mode which reveals most of the bugs.
E.g. something optimizing but with asserts. And use this mode for CC and
probably build snapshots in that mode.

Thanks,
Mikhail

>
>  thanks, Vladimir
> >
> > Thanks,
> > Stepan.
> >
> > >
> > > Regards,
> > > Tim
> > >
> >
>