Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 11967 invoked from network); 21 Jun 2007 21:05:05 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 21 Jun 2007 21:05:05 -0000 Received: (qmail 32089 invoked by uid 500); 21 Jun 2007 21:05:07 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 31776 invoked by uid 500); 21 Jun 2007 21:05:06 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 31767 invoked by uid 99); 21 Jun 2007 21:05:06 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jun 2007 14:05:06 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of t.p.ellison@gmail.com designates 64.233.166.179 as permitted sender) Received: from [64.233.166.179] (HELO py-out-1112.google.com) (64.233.166.179) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 21 Jun 2007 14:05:02 -0700 Received: by py-out-1112.google.com with SMTP id a29so1278680pyi for ; Thu, 21 Jun 2007 14:04:41 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding; b=UZRsZLD2nKmoklx1kl0gBWSmnD0c4p+fJQqkxHagDKoi86t9+Mqs0p6Xy9m3r5RI7VAc5WQmGU8Kr9/cvac1o9cfkUScWARZVkQkWvtNDpR/wnzD31NAqlurejg55Q+E/CEUq95ogCk17ZzpPNGeijQWuX1Ax3fhDXjEcm7N9rw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding; b=GJQAgenwhtnij/GBY0ORmGXPZPjxTcFjoplRLSHFISCaYkt4phty0drTiJI9IRF22bj5Ln1E+DE4nDPSWTO7ouNpQEWmewosaa4xAwBAEZ/FBpKPA2NjITmekhL8F1Z+29ZlnB4rVR7v8uakC1CBrzxwQP6aZGEFr2bhZDNdq/4= Received: by 10.65.59.11 with SMTP id m11mr4392563qbk.1182459881617; Thu, 21 Jun 2007 14:04:41 -0700 (PDT) Received: from ?192.168.0.2? ( [86.111.176.100]) by mx.google.com with ESMTP id f7sm1942360nfh.2007.06.21.14.04.40 (version=SSLv3 cipher=RC4-MD5); Thu, 21 Jun 2007 14:04:41 -0700 (PDT) Message-ID: <467AE7E4.5010303@gmail.com> Date: Thu, 21 Jun 2007 22:04:36 +0100 From: Tim Ellison User-Agent: Thunderbird 2.0.0.4 (Windows/20070604) MIME-Version: 1.0 To: dev@harmony.apache.org Subject: Re: [classlib][luni]some non ascii characters in String2Test References: <211709bc0706210307h53a0a260j97e55fc177e3cbef@mail.gmail.com> In-Reply-To: <211709bc0706210307h53a0a260j97e55fc177e3cbef@mail.gmail.com> X-Enigmail-Version: 0.95.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org Tony Wu wrote: > I found following line in java.lang.String2Test.java > > LINE464: "string".getBytes("?Q?D??_??_6ffa?+vG?_??���??"); > > I converted it to "?Q?D??_??_6ffa?+vG?_??\u951f\ufffd??" by > native2ascii and all tests passed, but I'm not sure if this fix is ok > since the "?" may indicate some unrecognized character in my locale? > What's your opinion? That test came from HARMONY-663, which is intended to test with an illegal character set name (legal name formats are defined here [1]). If you need to convert the test to ascii I think that is ok provided the name is charset name illegal. [1] http://java.sun.com/j2se/1.5.0/docs/api/java/nio/charset/Charset.html#names Regards, Tim