harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Hindess <mark.hind...@googlemail.com>
Subject Re: svn commit: r548917 - in /harmony/enhanced/buildtest/branches/2.0/tests/reliability: run/ src/java/org/apache/harmony/test/reliability/api/kernel/exec/ src/java/org/apache/harmony/test/reliability/api/kernel/hooks/ src/java/org/apache/harmony/test/reli...
Date Wed, 20 Jun 2007 09:54:31 GMT

Commit messages for a JIRA should include the full string "HARMONY-4144"
so that they can be cross-referenced.  They should also include at least
the title so that those reading the commit message don't have to look up
the JIRA for simple changes.

Stepan's comment on this JIRA specifically (and quite correctly) asks
that the JIRA attachment be re-submitted as a diff and not as complete
fixed files.  Aleksey agreed to do this.  However, you do not seem to
have waited for this to happen before committing the replacement files.
Obviously reading the commit message, we now have the diff and can see
that it is simply modifications, but we really should have the diff on
the JIRA before it is committed.

Regards,
 Mark.

On 20 June 2007 at 3:50, ivavladimir@apache.org wrote:
> Author: ivavladimir
> Date: Tue Jun 19 20:50:16 2007
> New Revision: 548917
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=548917
> Log:
> issue 4144 was fixed
> 
> Modified:
>     harmony/enhanced/buildtest/branches/2.0/tests/reliability/run/run.api.ker
> nel.xml
>     harmony/enhanced/buildtest/branches/2.0/tests/reliability/run/run.xml
>     harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/exec/ExecApplication.java
>     harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/exec/RunExec.java
>     harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/hooks/AddRmShtdwnHooksTest.java
>     harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/thread/RecursiveThreadTest/Recursive
> Test.java
>     harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/thread/VolatileVariableTest/DekkerTe
> st.java
>     harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/net/NetClient.java
>     harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/net/auxiliary/Test_lnx.out
>     harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/nio/channels/filechannel/FileChannelMapTest
> .java
> 
> Modified: harmony/enhanced/buildtest/branches/2.0/tests/reliability/run/run.a
> pi.kernel.xml
> URL: http://svn.apache.org/viewvc/harmony/enhanced/buildtest/branches/2.0/tes
> ts/reliability/run/run.api.kernel.xml?view=diff&rev=548917&r1=548916&r2=54891
> 7
> =============================================================================
> =
> --- harmony/enhanced/buildtest/branches/2.0/tests/reliability/run/run.api.ker
> nel.xml (original)
> +++ harmony/enhanced/buildtest/branches/2.0/tests/reliability/run/run.api.ker
> nel.xml Tue Jun 19 20:50:16 2007
> @@ -44,7 +44,7 @@
>     <target name="run.api.kernel.exec">
>     
>          <run-pjava-test test="api.kernel.exec.RunExec" args="${api.kernel.ex
> ec.RunExec.num_execs} 
> -        					${api.kernel.exec.RunExec.num_t
> hreads} ${test.classes.dir} ${jvm.under.test}" />
> +        					${api.kernel.exec.RunExec.num_t
> hreads} ${test.classes.dir} ${jvm.under.test} ${test.classes.dir}" />
>  
>     </target>
>  
> 
> Modified: harmony/enhanced/buildtest/branches/2.0/tests/reliability/run/run.x
> ml
> URL: http://svn.apache.org/viewvc/harmony/enhanced/buildtest/branches/2.0/tes
> ts/reliability/run/run.xml?view=diff&rev=548917&r1=548916&r2=548917
> =============================================================================
> =
> --- harmony/enhanced/buildtest/branches/2.0/tests/reliability/run/run.xml (or
> iginal)
> +++ harmony/enhanced/buildtest/branches/2.0/tests/reliability/run/run.xml Tue
>  Jun 19 20:50:16 2007
> @@ -20,12 +20,22 @@
>  
>      <description>Run reliability testsuite </description>
>  
> +    <condition property="exe" value=".exe" else="">
> +        <os family="windows"/>
> +    </condition>
> +
>      <!-- path to the tested runtime -->
> -    <property name="jvm.under.test" location="C:\jdk1.5.0_06\jre\bin\java" /
> > 
> +    <property name="jvm.under.test" location="${java.home}/bin/java${exe}" /
> > 
>  
>      <property name="jvm.args" value="-Xmx256m" /> 
>  
> -	<!-- This VM option may be needed as well: -Djava.security.policy= [...
> ]/config/java.policy	 -->
> +    <condition property="no.jvm.found">
> +        <not>
> +            <available file="${jvm.under.test}"/>
> +        </not>
> +    </condition>
> +
> +    <!-- This VM option may be needed as well: -Djava.security.policy= [...]
> /config/java.policy	 -->
>  
>      <!-- specify directory where tests can create their working files -->
>      <property name="work.dir" location="../work" />
> @@ -90,6 +100,13 @@
>          <attribute name="args" default=""/>
>          <element name="java-element" optional="true"/>
>          <sequential>
> +        <if>
> +            <isset property="no.jvm.found"/>
> +        <then>	
> +            <fail>Could not locate jvm executable to test, please, set "jvm.
> under.test" property.</fail>
> +        </then>
> +        </if>	
> +
>  	<if>
>  	    <not>
>  		<isset property="@{test}"/>
> 
> Modified: harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/
> org/apache/harmony/test/reliability/api/kernel/exec/ExecApplication.java
> URL: http://svn.apache.org/viewvc/harmony/enhanced/buildtest/branches/2.0/tes
> ts/reliability/src/java/org/apache/harmony/test/reliability/api/kernel/exec/E
> xecApplication.java?view=diff&rev=548917&r1=548916&r2=548917
> =============================================================================
> =
> --- harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/exec/ExecApplication.java (original)
> +++ harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/exec/ExecApplication.java Tue Jun 19
>  20:50:16 2007
> @@ -150,7 +150,8 @@
>              prnWriter = new PrintWriter(new BufferedWriter(new FileWriter(
>                  filename)));
>          } catch (IOException e) {
> -            e.printStackTrace();
> +            RunExec.log.add("Failed to create PrintWriter, file name: " + fi
> lename);
> +            return;
>          }
>  
>          try {
> @@ -159,14 +160,15 @@
>              }
>  
>          } catch (IOException e) {
> -            e.printStackTrace();
> +        	RunExec.log.add("Failed print into file: " + filename);
>          } finally {
>              try {
>                  prnWriter.close();
>                  bufReader.close();
>                  in.close();
>              } catch (IOException e) {
> -                e.printStackTrace();
> +                //e.printStackTrace();
> +            	// Expected 
>              }
>          }
>      }
> @@ -195,11 +197,11 @@
>                  }
>              }
>          } catch (FileNotFoundException e) {
> -            System.out.println("Read the content of the file" + filename + "
> . The file does not exist");
> -            e.printStackTrace();
> +            RunExec.log.add("Read the content of the file" + filename + ". T
> he file does not exist: " + e.getMessage());
> +            //e.printStackTrace();
>          } catch (IOException ee) {
> -            System.out.println("Read a line of text: I/O error occurs");
> -            ee.printStackTrace();
> +        	RunExec.log.add("Read a line of text: I/O error occurs: " + ee.
> getMessage());
> +            //ee.printStackTrace();
>          } finally {
>              try {
>                  bufReader.close();
> @@ -228,20 +230,20 @@
>              }
>          }
>          if (!result) {
> -            System.out.println("Line is not found in the file " + filename
> +        	RunExec.log.add("Line is not found in the file " + filename
>                  + ". Number of lines = " + strcounter);
> +        	return result;
>          }
>          strcounter = strcounter - 2;
>          if (strcounter != cntline) {
> -            System.out.println("Invalid number of lines in the file "
> +        	RunExec.log.add("Invalid number of lines in the file "
>                  + filename + ". Number of lines = " + strcounter);
>              result = false;
>          }
>          return result;
>      }
>  
> -    public boolean checkSomeLine(String filename, String linestartswith,
> -        String lineendswith, int cntline) {
> +    public boolean checkSomeLine2(String filename, String linestartswith, in
> t cntline) {
>          int strcounter = 0;
>          String line;
>          boolean result = false;
> @@ -249,7 +251,7 @@
>              line = readLineFromFile(filename, strcounter);
>              if (line != null) {
>                  for (int i = 0; i <= cntline; i++) {
> -                    if (checkLine(line, linestartswith, lineendswith)) {
> +                    if (checkLine(line, linestartswith, "")) {
>                          result = true;
>                          break;
>                      }
> @@ -258,7 +260,7 @@
>              }
>          }
>          if (!result) {
> -            System.out.println("Invalid number of lines in the file "
> +        	RunExec.log.add("Invalid number of lines in the file "
>                  + filename + ". Number of lines = " + strcounter);
>          }
>          return result;
> @@ -281,7 +283,7 @@
>              fln = listFiles[i].getName();
>              if (fln.equals(filename)) {
>                  if (!listFiles[i].delete()) {
> -                    System.out.println("delete " + fln + " : failed");
> +                	RunExec.log.add("delete " + fln + " : failed");
>                      return false;
>                  }
>  
> @@ -296,7 +298,7 @@
>          if (process != null) {
>              exitvalue = processWaitFor(process);
>              if (exitvalue != 104) {
> -                System.out.println("the exit value = " + exitvalue
> +            	RunExec.log.add("the exit value = " + exitvalue
>                      + " The exit value of the process should be 104.");
>              }
>          }
> 
> Modified: harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/
> org/apache/harmony/test/reliability/api/kernel/exec/RunExec.java
> URL: http://svn.apache.org/viewvc/harmony/enhanced/buildtest/branches/2.0/tes
> ts/reliability/src/java/org/apache/harmony/test/reliability/api/kernel/exec/R
> unExec.java?view=diff&rev=548917&r1=548916&r2=548917
> =============================================================================
> =
> --- harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/exec/RunExec.java (original)
> +++ harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/exec/RunExec.java Tue Jun 19 20:50:1
> 6 2007
> @@ -40,7 +40,6 @@
>  
>  public class RunExec extends Test {
>  
> -    int cnt = ExecApplication.getCnt();
>      String ins = ExecApplication.fileNameforIn();
>      String err = ExecApplication.fileNameforErr();
>      String ins_i;
> @@ -48,12 +47,9 @@
>      String line;
>      int secarg = 0;
>      int strcounter;
> +    String tmpFolder = System.getProperty("java.io.tmpdir");
>  
>      public int test(String params[]) {
> -        String userdir = System.getProperty("java.io.tmpdir") + File.separat
> or + "reliability_exec";
> -        File temp = new File(userdir);
> -        temp.mkdir();
> -
>          if (params.length >= 1) {
>              ExecApplication.setId(Integer.parseInt(params[0]));
>          }        
> @@ -70,6 +66,21 @@
>              ExecApplication.testedruntime = params[3];
>          }        
>  
> +        if (params.length >= 5) {
> +        	tmpFolder = params[4];
> +        }        
> +
> +        int cnt = ExecApplication.getCnt();
> +        
> +        String userdir = tmpFolder + File.separator + "reliability_exec";
> +        File temp = new File(userdir);
> +        if (!temp.exists())
> +        {
> +        	if (!temp.mkdir()){
> +        		return fail("Failed to create folder " + temp.getAbsolu
> tePath());
> +        	}
> +        }
> +        
>          String longstr = ShutdownHookApp.getLongString();
>  
>          for (int i = 0; i < cnt; i++) {
> @@ -92,8 +103,7 @@
>              }
>  
>              for (int j = 1; j < secarg; j++) {
> -                if (!ex.checkSomeLine(ins_i, ExecApplication.currThreadStr()
> , Integer
> -                    .toString(j), secarg)) {
> +                if (!ex.checkSomeLine2(ins_i, ExecApplication.currThreadStr(
> ), secarg)) {
>                      return fail("Check line from file " + ins_i
>                          + " : failed");
>                  }
> @@ -135,8 +145,7 @@
>              }
>  
>              for (int j = 1; j < secarg; j++) {
> -                if (!ex.checkSomeLine(ins_i, ExecApplication.currThreadStr()
> , Integer
> -                    .toString(j), secarg)) {
> +                if (!ex.checkSomeLine2(ins_i, ExecApplication.currThreadStr(
> ), secarg)) {
>                      return fail("Check line from file " + ins_i
>                          + " : failed");
>                  }
> 
> Modified: harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/
> org/apache/harmony/test/reliability/api/kernel/hooks/AddRmShtdwnHooksTest.jav
> a
> URL: http://svn.apache.org/viewvc/harmony/enhanced/buildtest/branches/2.0/tes
> ts/reliability/src/java/org/apache/harmony/test/reliability/api/kernel/hooks/
> AddRmShtdwnHooksTest.java?view=diff&rev=548917&r1=548916&r2=548917
> =============================================================================
> =
> --- harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/hooks/AddRmShtdwnHooksTest.java (ori
> ginal)
> +++ harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/hooks/AddRmShtdwnHooksTest.java Tue 
> Jun 19 20:50:16 2007
> @@ -384,7 +384,11 @@
>          Thread[] hooks = createHookThreads(Integer.parseInt(args[0]));
>  
>          for (int i = 0; i < hooks.length; ++ i){
> -            Runtime.getRuntime().addShutdownHook(hooks[i]);
> +            try{
> +                Runtime.getRuntime().addShutdownHook(hooks[i]);
> +            } catch (IllegalArgumentException iae){
> +                // Ignore
> +            }
>          }
>  
>      }
> @@ -411,7 +415,11 @@
>          Thread[] hooks = createExecutedHookThreads(Integer.parseInt(args[0])
> );
>  
>          for (int i = 0; i < hooks.length; ++ i){
> -            Runtime.getRuntime().addShutdownHook(hooks[i]);
> +            try{
> +                Runtime.getRuntime().addShutdownHook(hooks[i]);
> +            } catch (IllegalArgumentException iae){
> +                // Ignore
> +            }
>          }
>  
>      }
> 
> Modified: harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/
> org/apache/harmony/test/reliability/api/kernel/thread/RecursiveThreadTest/Rec
> ursiveTest.java
> URL: http://svn.apache.org/viewvc/harmony/enhanced/buildtest/branches/2.0/tes
> ts/reliability/src/java/org/apache/harmony/test/reliability/api/kernel/thread
> /RecursiveThreadTest/RecursiveTest.java?view=diff&rev=548917&r1=548916&r2=548
> 917
> =============================================================================
> =
> --- harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/thread/RecursiveThreadTest/Recursive
> Test.java (original)
> +++ harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/thread/RecursiveThreadTest/Recursive
> Test.java Tue Jun 19 20:50:16 2007
> @@ -43,7 +43,7 @@
>  
>  public class RecursiveTest extends Test {
>      
> -    public static int depth = 1000;
> +    public static int depth = 500;
>      public static int size = 1000;
>      public static volatile boolean finish = false;
>  
> @@ -98,7 +98,7 @@
>          // just wasting memory
>          Object[] array = new Object[RecursiveTest.size];
>          for (int i = 0; i < RecursiveTest.size; i++) {
> -            array[i] = new recurThread();
> +            array[i] = new char[10];
>          }
>      }
>  
> 
> Modified: harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/
> org/apache/harmony/test/reliability/api/kernel/thread/VolatileVariableTest/De
> kkerTest.java
> URL: http://svn.apache.org/viewvc/harmony/enhanced/buildtest/branches/2.0/tes
> ts/reliability/src/java/org/apache/harmony/test/reliability/api/kernel/thread
> /VolatileVariableTest/DekkerTest.java?view=diff&rev=548917&r1=548916&r2=54891
> 7
> =============================================================================
> =
> --- harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/thread/VolatileVariableTest/DekkerTe
> st.java (original)
> +++ harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/kernel/thread/VolatileVariableTest/DekkerTe
> st.java Tue Jun 19 20:50:16 2007
> @@ -188,8 +188,10 @@
>  
>              base.commonVar = vars[threadNum];
>              Thread.yield(); // to give a chance to another thread
> -            if (base.commonVar != vars[threadNum]) {
> +            if (base.commonVar != vars[0] &&
> +                base.commonVar != vars[1]) {
>                  base.statuses[threadNum] = DStatus.FAIL;
> +                regionOut(threadNum);
>                  return;
>              }
>              // end of critical region
> 
> Modified: harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/
> org/apache/harmony/test/reliability/api/net/NetClient.java
> URL: http://svn.apache.org/viewvc/harmony/enhanced/buildtest/branches/2.0/tes
> ts/reliability/src/java/org/apache/harmony/test/reliability/api/net/NetClient
> .java?view=diff&rev=548917&r1=548916&r2=548917
> =============================================================================
> =
> --- harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/net/NetClient.java (original)
> +++ harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/net/NetClient.java Tue Jun 19 20:50:16 2007
> @@ -80,6 +80,7 @@
>      private PrintWriter prnWriter;
>      private FileInputStream fis;
>      private static int clientcounter = 0;
> +    private final static int NUMBER_OF_TRIES_TO_START_SERVER = 50;
>  
>      private static int threadcnt = 0;
>      private static int cycle = 0;
> @@ -142,14 +143,24 @@
>  
>          
>          //log.add("PORT = " + PORT++);
> -
> -        try {    
> -            server = new ServerSocket(NetClient.PORT);
> -            //log.add("Creates a server socket " + server + ", bound to the"
>  + NetClient.PORT + " port");
> -        }  catch (Exception e) {
> -
> -            log.add("Creates a ServerSocket(" + NetClient.PORT + "): Excepti
> on during test execution");
> -            log.add(e);
> +        // try to create ServerSocket NUMBER_OF_TRIES_TO_START_SERVER times 
> with 
> +        // different PORT values as some PORT values could already be taken!
> +        int count = 0;
> +        while (count < NUMBER_OF_TRIES_TO_START_SERVER){
> +            try {    
> +                server = new ServerSocket(NetClient.PORT);
> +                log.add("Creates a server socket " + server + ", bound to th
> e" + NetClient.PORT + " port");
> +            }  catch (Exception e) {
> +                // try next PORT number
> +                count++;
> +                NetClient.PORT++;
> +                continue;
> +            }
> +            break;
> +        }
> +         
> +        if (server == null){
> +                log.add("Creates a ServerSocket in the range(" + NetClient.P
> ORT + ":" + NetClient.PORT + "): Exception during test execution");
>              return fail("Failed.");
>          }
>  
> @@ -200,29 +211,29 @@
>          //Creates some sockets and connects to the specified port 
>          while(true) {
>  
> -            if(threadcnt() < THREAD) {
> +                if(threadcnt() < THREAD) {
>  
> -                Client client =  new Client(ia);
> -            }
> +                       Client client =  new Client(ia);
> +                }
>  
> -            try {    
> -                Thread.currentThread().sleep(NetClient.SLEEP);
> -            }  catch (InterruptedException e) {
> -                log.add(e);
> -                return fail("another thread has interrupted the current thre
> ad");
> +                try {    
> +                    Thread.currentThread().sleep(NetClient.SLEEP);
> +                }  catch (InterruptedException e) {
> +                    log.add(e);
> +                    return fail("another thread has interrupted the current 
> thread");
>  
> -            }
> -            if(cnt() == CNT) {
> -                clientcounter = 0;
> -                break;
> -            }
> +                 }
> +                if(cnt() == CNT) {
> +                    clientcounter = 0;
> +                    break;
> +                }
>          }
>  
>  
>          if (result()) {
> -            return pass("OK");
> +                return pass("OK");
>          } else {
> -            return fail("Failed.");
> +                return fail("Failed.");
>          }
>      }
>  
> @@ -325,11 +336,11 @@
>  
>              // arrays to be tested for equality
>              if(java.util.Arrays.equals(a, b)) {
> -                //log.add("checks "+ filename + " : true");
> -                return true;
> +                    //log.add("checks "+ filename + " : true");
> +                    return true;
>              } else {
> -                log.add("checks "+ filename + " : false");        
> -                return false;
> +                    log.add("checks "+ filename + " : false");        
> +                    return false;
>              }
>          }
>  
> @@ -378,8 +389,8 @@
>                  bufReader.close();
>                  in.close();
>              }  catch (Exception e) {
> -                log.add(e);
> -                log.add("error occurs when closing the streams");
> +                    log.add(e);
> +                    log.add("error occurs when closing the streams");
>              } finally {
>                  try {
>                      socket.close();
> 
> Modified: harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/
> org/apache/harmony/test/reliability/api/net/auxiliary/Test_lnx.out
> URL: http://svn.apache.org/viewvc/harmony/enhanced/buildtest/branches/2.0/tes
> ts/reliability/src/java/org/apache/harmony/test/reliability/api/net/auxiliary
> /Test_lnx.out?view=diff&rev=548917&r1=548916&r2=548917
> =============================================================================
> =
> --- harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/net/auxiliary/Test_lnx.out (original)
> +++ harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/net/auxiliary/Test_lnx.out Tue Jun 19 20:50
> :16 2007
> @@ -1,37 +1,37 @@
> -public class Test {
> -    static void createFrame() {
> -	new javax.swing.JFrame();
> -        System.out.println("PASSED"); 
> -    } 
> -    public static void main(String args[]) throws Exception { 
> -        javax.swing.SwingUtilities.invokeLater(new Runnable() {public void r
> un() { createFrame(); }});
> -    } 
> -} 
> -public class Test {
> -    static void createFrame() {
> -	new javax.swing.JFrame();
> -        System.out.println("PASSED"); 
> -    } 
> -    public static void main(String args[]) throws Exception { 
> -        javax.swing.SwingUtilities.invokeLater(new Runnable() {public void r
> un() { createFrame(); }});
> -    } 
> -} 
> -public class Test {
> -    static void createFrame() {
> -	new javax.swing.JFrame();
> -        System.out.println("PASSED"); 
> -    } 
> -    public static void main(String args[]) throws Exception { 
> -        javax.swing.SwingUtilities.invokeLater(new Runnable() {public void r
> un() { createFrame(); }});
> -    } 
> -} 
> -public class Test {
> -    static void createFrame() {
> -	new javax.swing.JFrame();
> -        System.out.println("PASSED"); 
> -    } 
> -    public static void main(String args[]) throws Exception { 
> -        javax.swing.SwingUtilities.invokeLater(new Runnable() {public void r
> un() { createFrame(); }});
> -    } 
> -} 
> -
> +public class Test {
> +    static void createFrame() {
> +	new javax.swing.JFrame();
> +        System.out.println("PASSED"); 
> +    } 
> +    public static void main(String args[]) throws Exception { 
> +        javax.swing.SwingUtilities.invokeLater(new Runnable() {public void r
> un() { createFrame(); }});
> +    } 
> +} 
> +public class Test {
> +    static void createFrame() {
> +	new javax.swing.JFrame();
> +        System.out.println("PASSED"); 
> +    } 
> +    public static void main(String args[]) throws Exception { 
> +        javax.swing.SwingUtilities.invokeLater(new Runnable() {public void r
> un() { createFrame(); }});
> +    } 
> +} 
> +public class Test {
> +    static void createFrame() {
> +	new javax.swing.JFrame();
> +        System.out.println("PASSED"); 
> +    } 
> +    public static void main(String args[]) throws Exception { 
> +        javax.swing.SwingUtilities.invokeLater(new Runnable() {public void r
> un() { createFrame(); }});
> +    } 
> +} 
> +public class Test {
> +    static void createFrame() {
> +	new javax.swing.JFrame();
> +        System.out.println("PASSED"); 
> +    } 
> +    public static void main(String args[]) throws Exception { 
> +        javax.swing.SwingUtilities.invokeLater(new Runnable() {public void r
> un() { createFrame(); }});
> +    } 
> +} 
> +
> 
> Modified: harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/
> org/apache/harmony/test/reliability/api/nio/channels/filechannel/FileChannelM
> apTest.java
> URL: http://svn.apache.org/viewvc/harmony/enhanced/buildtest/branches/2.0/tes
> ts/reliability/src/java/org/apache/harmony/test/reliability/api/nio/channels/
> filechannel/FileChannelMapTest.java?view=diff&rev=548917&r1=548916&r2=548917
> =============================================================================
> =
> --- harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/nio/channels/filechannel/FileChannelMapTest
> .java (original)
> +++ harmony/enhanced/buildtest/branches/2.0/tests/reliability/src/java/org/ap
> ache/harmony/test/reliability/api/nio/channels/filechannel/FileChannelMapTest
> .java Tue Jun 19 20:50:16 2007
> @@ -204,5 +204,11 @@
>              }
>  
>          }
> +        try {
> +            fc.close();
> +        } catch (IOException e) {
> +            // Expected
> +        }
> +
>      }
>  }
> 





Mime
View raw message