Return-Path: 
 <dev-return-26841-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org>
Delivered-To: apmail-harmony-dev-archive@www.apache.org
Received: (qmail 96557 invoked from network); 4 May 2007 10:05:31 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 4 May 2007 10:05:31 -0000
Received: (qmail 32595 invoked by uid 500); 4 May 2007 10:05:34 -0000
Delivered-To: apmail-harmony-dev-archive@harmony.apache.org
Received: (qmail 32569 invoked by uid 500); 4 May 2007 10:05:34 -0000
Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@harmony.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@harmony.apache.org>
List-Post: <mailto:dev@harmony.apache.org>
List-Id: <dev.harmony.apache.org>
Reply-To: dev@harmony.apache.org
Delivered-To: mailing list dev@harmony.apache.org
Received: (qmail 32560 invoked by uid 99); 4 May 2007 10:05:34 -0000
Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 May 2007 03:05:34 -0700
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (herse.apache.org: domain of t.p.ellison@gmail.com
 designates 66.249.92.169 as permitted sender)
Received: from [66.249.92.169] (HELO ug-out-1314.google.com) (66.249.92.169)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 May 2007 03:05:27 -0700
Received: by ug-out-1314.google.com with SMTP id z36so461289uge
        for <dev@harmony.apache.org>; Fri, 04 May 2007 03:05:06 -0700 (PDT)
DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed;
        d=gmail.com; s=beta;
        h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding;
        b=RXPe8objZVAQsAYkmegz5/vBa5+vgiVASRnIWx/PuF8cFmozMZTK3sOz7/lBrKZP2lLrHPAeSMJw1zfQsP5y4KY/nSc8saAy76zHtpYu2CkCl+dnRnOJmfPPHcKfbApCyy5ZL2a37CO2Zh+OWDcXcfqqaCFWkfFvWgqLqfOssPA=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding;
        b=XdFC4k0LDT2SpqvlJ0QnTpkcoL5h8BSJ7A22cqmmr6zKRVmgtCNNaIRagd7AP1vHSyxK5hdZf5RfX7cYcs9kJ2jo1/7HK5Y32yUbhIwYJTt4Xe7oWV1uvGi7zbdi85+fsYyOdkNfLA5iOYC7Oz6+euamGr8A/kGZfcHa9c6z8SA=
Received: by 10.67.98.9 with SMTP id a9mr2622728ugm.1178273106391;
        Fri, 04 May 2007 03:05:06 -0700 (PDT)
Received: from ?192.168.0.2? ( [86.111.176.100])
        by mx.google.com with ESMTP id 72sm4058299ugb.2007.05.04.03.05.05;
        Fri, 04 May 2007 03:05:05 -0700 (PDT)
Message-ID: <463B0550.5030201@gmail.com>
Date: Fri, 04 May 2007 11:05:04 +0100
From: Tim Ellison <t.p.ellison@gmail.com>
User-Agent: Thunderbird 1.5.0.10 (Windows/20070221)
MIME-Version: 1.0
To: dev@harmony.apache.org
Subject: Re: [classlib][tools] Removing tools module
References: <46386C53.90106@gmail.com>
	 <2c9597b90705020713n7fcd43c3seb6bcda373b7941f@mail.gmail.com>
	 <b6cb498e0705020846u1c7d1c36jbc9c056def07ae5c@mail.gmail.com>
	 <2c9597b90705020941v37af03f8h393235751a221951@mail.gmail.com>
	 <7273946b0705021908v459a18b2se65bbbea83936312@mail.gmail.com>
	 <4639A05A.3080603@gmail.com>
	 <7273946b0705030242q2bc65cdeg2bdefdee9232e9fe@mail.gmail.com>
	 <4639B907.10202@gmail.com>
	 <b6cb498e0705030623j591e548et48f5ebb526a3794c@mail.gmail.com>
	 <4639F3B7.2060708@gmail.com>
 <b6cb498e0705031037g41f1b93escec34a991a769291@mail.gmail.com>
In-Reply-To: <b6cb498e0705031037g41f1b93escec34a991a769291@mail.gmail.com>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org

Ivan Popov wrote:
>> Can you try this patch in working_jdktools/modules/jpda/src/ and let me
>> know if it fixes the problem:
<snip>
> 
> Yes, it should fix the problem locally (on 64-bit Linux it will
> produce two -fpic). But, I''d prefer to put it to common platform
> dependent settings for Linux/x86. I'm not sure it will work for
> freebsd or macos.

Ok, I'll fix it locally for now until we decide it is safe to apply
'globally'.

>> > The other minor problem is that classlib's make scripts don't define
>> > NDEBUG macro for release mode, so all debug/trace code is included
>> > into release build. This also should be fixed.
>>
>> Sorry, which macro is that?
> 
> This macro controls compilation of standard assert() macro (man
> assert) and is usually used for adding debug and tracing stuff to
> debug builds. It is intensively used in JPDA code to facilitate
> tracing JPDA support. I've found it also in some classlib modules. It
> makes sense to add setting this macro for release build.
> 
> MSVC also uses _DEBUG macro for C++ runtime, which is set
> automatically in debug mode. But it's MSVC specific.

I'll take a look (I couldn't see it in classlib code).

Regards,
Tim