harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Popov" <ivan.g.po...@gmail.com>
Subject Re: [classlib][tools] Removing tools module
Date Fri, 04 May 2007 10:31:09 GMT
It seems that local fix does not work, local settings for CFLAGS don't
affect final command line for gcc, so it still misses -fpic.

Thanks.
Ivan

On 5/4/07, Tim Ellison <t.p.ellison@gmail.com> wrote:
> Ivan Popov wrote:
> >> Can you try this patch in working_jdktools/modules/jpda/src/ and let me
> >> know if it fixes the problem:
> <snip>
> >
> > Yes, it should fix the problem locally (on 64-bit Linux it will
> > produce two -fpic). But, I''d prefer to put it to common platform
> > dependent settings for Linux/x86. I'm not sure it will work for
> > freebsd or macos.
>
> Ok, I'll fix it locally for now until we decide it is safe to apply
> 'globally'.
>
> >> > The other minor problem is that classlib's make scripts don't define
> >> > NDEBUG macro for release mode, so all debug/trace code is included
> >> > into release build. This also should be fixed.
> >>
> >> Sorry, which macro is that?
> >
> > This macro controls compilation of standard assert() macro (man
> > assert) and is usually used for adding debug and tracing stuff to
> > debug builds. It is intensively used in JPDA code to facilitate
> > tracing JPDA support. I've found it also in some classlib modules. It
> > makes sense to add setting this macro for release build.
> >
> > MSVC also uses _DEBUG macro for C++ runtime, which is set
> > automatically in debug mode. But it's MSVC specific.
>
> I'll take a look (I couldn't see it in classlib code).
>
> Regards,
> Tim
>

Mime
View raw message