Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Received-SPF: pass (herse.apache.org: domain of alexei.zakharov@gmail.com
 designates 209.85.134.186 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=jLJynKWK7jmqMXa3E2mt4uftkWIIOOBdS3/ydV1SZ9MSgEiz2DnHcx6MS4yhzp75yrXVxtu5/DRI7f+jiTAkpiOyUw649AGy+ZlBxkhlYVQ3NmwXYHQf98Ileb7QiwfdySm2MudXZmCYDqv9dAalFmOy7r6tNoEDGz6UFtu3fo8=
Message-ID: <2c9597b90704260946v67ebfad2k43b29fab04c652b4@mail.gmail.com>
Date: Thu, 26 Apr 2007 20:46:36 +0400
From: "Alexei Zakharov" <alexei.zakharov@gmail.com>
To: dev@harmony.apache.org
Subject: Re: Eclipse doesn't find harmony sources
In-Reply-To: <3b3f27c60704251746g614a7364k5fa14b20ef221c83@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <016d01c786bf$d21ed520$d2012b0a@MARVIN>
	 <3b3f27c60704241732se2228aau2db02e51766c0388@mail.gmail.com>
	 <2c9597b90704250736o4aaf9635l7606c87ddab597ce@mail.gmail.com>
	 <3b3f27c60704251746g614a7364k5fa14b20ef221c83@mail.gmail.com>

Thanks. FYI HARMONY-3764 was created to track this. The fix just was
committed, so now we should have src-jars for all jars generated by
the build. Actually only sources for kernel classes make sense.
However, I decided to leave other src-jars (for gc_cc, gc_gen and
hythr, with simple stub helpers) for consistency. Hope I didn't break
anything.

Regards,

2007/4/26, Nathan Beyer <ndbeyer@apache.org>:
> On 4/25/07, Alexei Zakharov <alexei.zakharov@gmail.com> wrote:
> > > > I also can't find the source for kernel.jar. Where is Object.java,
> > > > Class.java, etc.?
> >
> > > Good question. There maybe a missing step here in our build scripts.
> > > All of the other source JARs are part of the "classlib" build, but
> > > kernel.jar is produced (implemented) by the VM, so this would be part
> > > of the "drlvm" build. I'll look into this one.
> >
> > I'm currently fixing various issues in DRLVM build. So I think I can
> > also handle this one too since I'm in context. However, if you want to
> > do it by yourself please go ahead.
>
> Sure, go ahead, you'll probably get to it much faster than I.
> -Nathan
>
> >
> > With Best Regards,
> >
> > 2007/4/25, Nathan Beyer <ndbeyer@apache.org>:
> > > On 4/24/07, Wayne Beaton <wayne@eclipse.org> wrote:
> > > > When you add a JRE to Eclipse, it scans the JRE's directory for JAR files.
> > > > For each JAR file it finds, it looks for corresponding source. It does so by
> > > > climbing up the containment hierarchy looking for a file named "src.jar" or
> > > > "src.zip" (if you're curious, see
> > > > org.eclipse.jdt.internal.launching.StandardVMType#getDefaultSystemLibrarySou
> > > > rce()).
> > > >
> > > > Harmony JDK doesn't store is source this way (it seems to include the
> > > > sources alongside the JAR files), so Eclipse doesn't find it (which means
> > > > that if, for example, you browse the class java.lang.String, you get a
> > > > "can't find the source" message in your editor).
> > > >
> > > > Is there a special reason why Harmony sources are represented the way they
> > > > are? Is there any way to bundle 'em all up into a src.zip file?
> > >
> > > No special reason, that I know of. Personally, I would consider the
> > > JRE's source bundling to be the odd ball (Eclipse source distribution
> > > is also a little weird and a personal pain point, but that's another
> > > story). I would consider packaging sources the way Harmony does a
> > > defacto standard; every JAR has a companion source JAR. In fact build
> > > systems like Maven default to this practice.
> > >
> > > >
> > > > In a related question, I'm not sure that putting them in the "jre" directory
> > > > is the right approach. I tend to think of the JRE directory as containing
> > > > *only* the JRE (i.e. I could yank it out and use it as a JRE) and the
> > > > sources--being part of the JDK--are outside of that directory.
> > > >
> > > > I also can't find the source for kernel.jar. Where is Object.java,
> > > > Class.java, etc.?
> > > >
> > >
> > > Good question. There maybe a missing step here in our build scripts.
> > > All of the other source JARs are part of the "classlib" build, but
> > > kernel.jar is produced (implemented) by the VM, so this would be part
> > > of the "drlvm" build. I'll look into this one.
> > >
> > > > I can understand why you'd want to have the sources in different files.
> > > > Eclipse handles J9 specially. It's probably time to generalize it's
> > > > implementation to handle arbitrary source configurations (perhaps via
> > > > extension point).
> > >
> > > Yes please!
> > >
> > > >
> > > > Wayne
> > > > --
> > > > Wayne Beaton
> > > > The Eclipse Foundation
> > > > wayne.beaton@eclipse.org
> > > > Skype, YIM: waynebeaton
> > > > http://www.eclipse.org
> > > > http://wbeaton.blogspot.com/
> > > > http://www.planeteclipse.org/planet/


-- 
Alexei Zakharov,
Intel ESSD