From dev-return-26476-apmail-harmony-dev-archive=harmony.apache.org@harmony.apache.org Wed Apr 25 14:37:12 2007 Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 23824 invoked from network); 25 Apr 2007 14:37:11 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 25 Apr 2007 14:37:11 -0000 Received: (qmail 89158 invoked by uid 500); 25 Apr 2007 14:37:15 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 89129 invoked by uid 500); 25 Apr 2007 14:37:15 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 89120 invoked by uid 99); 25 Apr 2007 14:37:15 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Apr 2007 07:37:15 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of alexei.zakharov@gmail.com designates 209.85.134.184 as permitted sender) Received: from [209.85.134.184] (HELO mu-out-0910.google.com) (209.85.134.184) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 Apr 2007 07:37:07 -0700 Received: by mu-out-0910.google.com with SMTP id w1so258691mue for ; Wed, 25 Apr 2007 07:36:45 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=aYT1PhbUPEkm2OApovfOcoqJFxyCBgJj244reJwaaonlhI5Nt1plx34/0k4GIwAJqRyIT0/7hSeIAeV6DxIz8xJbjwdoV6gPRndlzaLuASyJGaOOPXOSvVCchayPiOt3vcjd5Wk+NoP/NShCYiC+lg8sEIzgGaeI2Wgbef/TH/s= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=M4QX0M7vxeyW2iGzQa11tPPsLayNV2eRQ/0Xip1bkUmWAGVIAsF2hRS9T3uvqfZ1XVDQhmtOyuXezgYO51oP5aXqkyaY8Rmq7jRW9EXx/SLUDFNvax1/NC3xF0flOwMuyVRRgoO3hnURTa2EuKksTfdjQrGh95Jdu+/HY9ZzpJw= Received: by 10.82.145.7 with SMTP id s7mr1356743bud.1177511805343; Wed, 25 Apr 2007 07:36:45 -0700 (PDT) Received: by 10.82.107.19 with HTTP; Wed, 25 Apr 2007 07:36:45 -0700 (PDT) Message-ID: <2c9597b90704250736o4aaf9635l7606c87ddab597ce@mail.gmail.com> Date: Wed, 25 Apr 2007 18:36:45 +0400 From: "Alexei Zakharov" To: dev@harmony.apache.org Subject: Re: Eclipse doesn't find harmony sources In-Reply-To: <3b3f27c60704241732se2228aau2db02e51766c0388@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <016d01c786bf$d21ed520$d2012b0a@MARVIN> <3b3f27c60704241732se2228aau2db02e51766c0388@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org > > I also can't find the source for kernel.jar. Where is Object.java, > > Class.java, etc.? > Good question. There maybe a missing step here in our build scripts. > All of the other source JARs are part of the "classlib" build, but > kernel.jar is produced (implemented) by the VM, so this would be part > of the "drlvm" build. I'll look into this one. I'm currently fixing various issues in DRLVM build. So I think I can also handle this one too since I'm in context. However, if you want to do it by yourself please go ahead. With Best Regards, 2007/4/25, Nathan Beyer : > On 4/24/07, Wayne Beaton wrote: > > When you add a JRE to Eclipse, it scans the JRE's directory for JAR files. > > For each JAR file it finds, it looks for corresponding source. It does so by > > climbing up the containment hierarchy looking for a file named "src.jar" or > > "src.zip" (if you're curious, see > > org.eclipse.jdt.internal.launching.StandardVMType#getDefaultSystemLibrarySou > > rce()). > > > > Harmony JDK doesn't store is source this way (it seems to include the > > sources alongside the JAR files), so Eclipse doesn't find it (which means > > that if, for example, you browse the class java.lang.String, you get a > > "can't find the source" message in your editor). > > > > Is there a special reason why Harmony sources are represented the way they > > are? Is there any way to bundle 'em all up into a src.zip file? > > No special reason, that I know of. Personally, I would consider the > JRE's source bundling to be the odd ball (Eclipse source distribution > is also a little weird and a personal pain point, but that's another > story). I would consider packaging sources the way Harmony does a > defacto standard; every JAR has a companion source JAR. In fact build > systems like Maven default to this practice. > > > > > In a related question, I'm not sure that putting them in the "jre" directory > > is the right approach. I tend to think of the JRE directory as containing > > *only* the JRE (i.e. I could yank it out and use it as a JRE) and the > > sources--being part of the JDK--are outside of that directory. > > > > I also can't find the source for kernel.jar. Where is Object.java, > > Class.java, etc.? > > > > Good question. There maybe a missing step here in our build scripts. > All of the other source JARs are part of the "classlib" build, but > kernel.jar is produced (implemented) by the VM, so this would be part > of the "drlvm" build. I'll look into this one. > > > I can understand why you'd want to have the sources in different files. > > Eclipse handles J9 specially. It's probably time to generalize it's > > implementation to handle arbitrary source configurations (perhaps via > > extension point). > > Yes please! > > > > > Wayne > > -- > > Wayne Beaton > > The Eclipse Foundation > > wayne.beaton@eclipse.org > > Skype, YIM: waynebeaton > > http://www.eclipse.org > > http://wbeaton.blogspot.com/ > > http://www.planeteclipse.org/planet/ -- Alexei Zakharov, Intel ESSD