harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Naveen Neelakantam <neela...@uiuc.edu>
Subject Re: [drlvm][jit] abcd and devirtualizer patches was: [OT] Harmony used in accepted research paper
Date Fri, 20 Apr 2007 20:20:59 GMT

On Apr 18, 2007, at 12:24 AM, Pavel Ozhdikhin wrote:

> Naveen,
>

<snip>

> BTW what is the problem you encountered with identifying abstract  
> calls? I'm
> talking about this comment:in ValueProfiler.cpp:
>
> // Note: for some strange reason, we can't always positively identify
> abstract calls
>
> If there is a bug I believe we should fix it.

I believe it is safe to remove the following lines from  
ValueProfiler.cpp:

     // Note: for some strange reason, we can't always positively  
identify abstract calls
     if(profileAbstractCalls) {
         profileAllVirtualCalls = true;
     }

I can't reproduce the issue that caused me to put those lines in the  
code.

Naveen

> -Pavel

<snip>

Mime
View raw message