harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivanov, Alexey A" <alexey.a.iva...@intel.com>
Subject RE: [jira][swing] Could someone please commit HARMONY-3454 ?
Date Tue, 10 Apr 2007 06:30:13 GMT
>-----Original Message-----
>From: nbeyer@gmail.com [mailto:nbeyer@gmail.com] On Behalf Of Nathan
Beyer
>Sent: Tuesday, April 10, 2007 8:42 AM
>To: dev@harmony.apache.org
>Subject: Re: [jira][swing] Could someone please commit HARMONY-3454 ?
>
>I have a few comments about the patch -
>
>1. I think the "catch(Throwable)" in JEditorPane should be change, at
>a minimum, to "catch(Exception)". We don't want to hide things like
>OutOfMemoryErrors, which could happen anywhere.

Good point.

>
>2. There's no concurrency protection for the static Map, contentTypes.
>I realize that many parts of Swing and AWT aren't thread safe, but
>this doesn't seem like one of them. Perhaps this wasn't properly
>protected before, but we should add it now.

AWT is supposed to be thread-safe whereas Swing is not. JavaDoc for
Swing and its tutorials state Swing is not thread-safe if the doc
doesn't clearly state that a method, class is thread-safe. And in all
Swing examples provided by Sun, GUI initialization is performed in Event
Dispatch Thread rather than main thread.

That's why there was no concurrency protection here, and that's why it
was not implemented now. Of course it may be added...


Regards,
Alexey.


--
Alexey A. Ivanov
Intel Enterprise Solutions Software Division


>
>-Nathan
>
>On 4/9/07, Zakharov, Vasily M <vasily.m.zakharov@intel.com> wrote:
>> Hi,
>>
>> Could someone please commit
>> http://issues.apache.org/jira/browse/HARMONY-3454 ?
>>
>> It has patch available and it looks like the discussion over it is
over.
>>
>> Thank you!
>>
>> Vasily Zakharov
>> Intel ESSD
>>

Mime
View raw message