harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "LvJimmy,Jing" <firep...@gmail.com>
Subject Re: [classlib][luni]Delete DatagramSocket.isMulticastSocket?
Date Tue, 10 Apr 2007 07:00:56 GMT
Sounds reasonable. :)
I suggest you can just add patch on JIRA-3572, or raise a new JIRA yourself

2007/4/10, Sean Qiu <sean.xx.qiu@gmail.com>:
> There is also some methods in java.util.zip.ZipEntry seems useless who
> are never called.
> They are long getOffset (), void setName (String),  void setOffset (long).
>
> So i suggest delete them together, if no one objects.
>
> 2007/4/5, Leo Li <liyilei1979@gmail.com>:
> >  +1
> >  Delete them if they are dead code.:)
> >
> >
> > On 4/4/07, LvJimmy,Jing <firepure@gmail.com> wrote:
> > >
> > > I find another un-used method, Channels.wrapByteBuffer just now (it is
> > > very strange that it appears in class Channels!)
> > >
> > > Yes, as they are all in module LUNI, it may be easier to patch
> > > together. And before delete them, we'd better test carefully to see if
> > > native code or vm use them :)
> > >
> > > I've raised JIRA-3572 for these issue.
> > >
> > > 2007/4/4, Ruth Cao <ruoshen.c@gmail.com>:
> > > > I've also found there is a redundant constructor in
> > > > java.io.OptionalDataException: OptionalDataException(String). It seems
> > > > that we can eliminate these methods together :-)
> > > >
> > > > LvJimmy,Jing wrote:
> > > > > Hi All,
> > > > >
> > > > > I happen to meet a package private method of DatagramSocket(and
> > > > > its child class MulticastSocket), named isMulticastSocket. I search
in
> > > > > the luni package but find no line refers to this method. And a simple
> > > > > search in native code shows no native code refers to this method
by
> > > > > reflection.
> > > > > I doubt we can still tell if a datagram socket is multi-cast
> > > > > without this method, and what's more, the method currently seems
no
> > > > > use at all, and luni test passed without it.
> > > > > Do someone the use (or history) of the method? If no, I'd like
> > > > > add a patch to delete it.
> > > > >
> > > > --
> > > >
> > > > Regards,
> > > >
> > > > Ruth Cao
> > > > China Software Development Lab, IBM
> > > >
> > > >
> > > >
> > >
> > >
> > > --
> > >
> > > Best Regards!
> > >
> > > Jimmy, Jing Lv
> > > China Software Development Lab, IBM
> > >
> >
> >
> >
> > --
> > Leo Li
> > China Software Development Lab, IBM
> >
>
>
> --
> Sean Qiu
>


-- 

Best Regards!

Jimmy, Jing Lv
China Software Development Lab, IBM
Mime
View raw message