harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Zhang" <zhanghuang...@gmail.com>
Subject Re: [classlib][luni] new test in tests.api.java.net.SocketTest failed on my Windows XP sp2
Date Wed, 18 Apr 2007 18:56:13 GMT
On 4/18/07, Tim Ellison <t.p.ellison@gmail.com> wrote:
>
> Andrew Zhang wrote:
> > On 4/18/07, LvJimmy,Jing <firepure@gmail.com> wrote:
> >>
> >> This method is good, but not perfect, for
> >> 1. getNextPortsForUDP get a free port by a mechanism "get and
> >> release", but release the port may not be successful (e.g, in linux)
> >>
> > 2. even it releases successfully, during the period between utility
> >> method "release" and serversocket reuse it, there may be some other
> >> program reuse the port, which cause the test fail again.
> >
> >
> > Open and close is not safe in theory, as we discussed before.
> > Let's stop getNextPort, and stick to use port 0. :) I think we have
> agreed
> > that a long time ago.
>
> Yes.
>
> > 3. this may cost much more time to get a port.
> >>
> > The perfect solution for this is re-write the testcases, create
> >> ServerSocket with port 0, and then get the local port for socket to
> >> connect. However I guess it may cause a lot of affect.
> >
> >
> > yes, but we can do it lazily and gradually. The important thing is that
> we
> > should not use the buggy getNextPort any more....
>
> I agree, how about we mark it @deprecated to help remind people?


Good idea,  +1 !

Regards,
> Tim
>
>


-- 
Best regards,
Andrew Zhang

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message