harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer" <ndbe...@apache.org>
Subject Re: [jira][swing] Could someone please commit HARMONY-3454 ?
Date Tue, 10 Apr 2007 04:41:49 GMT
I have a few comments about the patch -

1. I think the "catch(Throwable)" in JEditorPane should be change, at
a minimum, to "catch(Exception)". We don't want to hide things like
OutOfMemoryErrors, which could happen anywhere.

2. There's no concurrency protection for the static Map, contentTypes.
I realize that many parts of Swing and AWT aren't thread safe, but
this doesn't seem like one of them. Perhaps this wasn't properly
protected before, but we should add it now.


On 4/9/07, Zakharov, Vasily M <vasily.m.zakharov@intel.com> wrote:
> Hi,
> Could someone please commit
> http://issues.apache.org/jira/browse/HARMONY-3454 ?
> It has patch available and it looks like the discussion over it is over.
> Thank you!
> Vasily Zakharov
> Intel ESSD

View raw message