harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zakharov, Vasily M" <vasily.m.zakha...@intel.com>
Subject RE: [jira][swing] Could someone please commit HARMONY-3454 ?
Date Tue, 10 Apr 2007 14:27:00 GMT

Thanks for checking the patch, Nathan!

1.1. The problem is the wrapped fragment performs class loading, and
can easily produce LinkageError, ExceptionInInitializerError,
IllegalAccessError
etc. and all these must not disrupt the code operation.

1.2. It is a question of compatibility. RI seems to catch everything
at this point, including ThreadDeath. :(

2.1. Adding synchronization is not a problem at all. But:

2.2. What is a point to make a tread-safe point in non-thread-safe
package?
If user can't and shouldn't rely on internal thread-safety and must
think
of synchronization himself, why waste performance (probably twice, as
user
provides his own synchronization) to provide thread-safety in one
particular
place? Isn't it a drop in the ocean?

2.3. The only reason I see for adding the synchronization here is RI
uses
Hashtable that is synchronized, and we probably would like to be
compatible
in this manner.

 Vasily


-----Original Message-----
From: nbeyer@gmail.com [mailto:nbeyer@gmail.com] On Behalf Of Nathan
Beyer
Sent: Tuesday, April 10, 2007 8:42 AM
To: dev@harmony.apache.org
Subject: Re: [jira][swing] Could someone please commit HARMONY-3454 ?

I have a few comments about the patch -

1. I think the "catch(Throwable)" in JEditorPane should be change, at
a minimum, to "catch(Exception)". We don't want to hide things like
OutOfMemoryErrors, which could happen anywhere.

2. There's no concurrency protection for the static Map, contentTypes.
I realize that many parts of Swing and AWT aren't thread safe, but
this doesn't seem like one of them. Perhaps this wasn't properly
protected before, but we should add it now.

-Nathan

On 4/9/07, Zakharov, Vasily M <vasily.m.zakharov@intel.com> wrote:
> Hi,
>
> Could someone please commit
> http://issues.apache.org/jira/browse/HARMONY-3454 ?
>
> It has patch available and it looks like the discussion over it is
over.
>
> Thank you!
>
> Vasily Zakharov
> Intel ESSD
>

Mime
View raw message