harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Zakharov" <alexei.zakha...@gmail.com>
Subject Re: Revision 528479 broke windows build - Applying slightly modified version of patch for HARMONY-3570 ([classlib][awt] Png decoder does not work on Linux x86_64)
Date Thu, 19 Apr 2007 12:42:27 GMT
(better late than never)
Thanks guys. I've committed the corrected version of the patch a few days ago.

Alexei

2007/4/15, Alexey Petrenko <alexey.a.petrenko@gmail.com>:
> Nathan,
>
> Yes, I can reproduce the windows build failure with the original patch
> by Andrey and modified patch by Alexei.
>
> Thanks for investigating the issue and reverting the patch back.
>
> I'll prepare a new patch.
>
> SY, Alexey
>
> 2007/4/15, Nathan Beyer <ndbeyer@apache.org>:
> > This commit seems to have broken the Windows build [1][2] - Applying
> > slightly modified version of patch for HARMONY-3570 ([classlib][awt]
> > Png decoder does not work on Linux x86_64).
> >
> > It causes a compiler warning, which is treated as an error in the file
> > pngdecoder.c at line 337. The comparison is between a signed and an
> > unsigned type.
> >
> > If someone can fix it shortly, cool, otherwise I'll roll it back a little later.
> >
> > -Nathan
> >
> > [1] https://svn.apache.org/viewvc?view=rev&revision=528479
> > [2] https://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/awt/src/main/native/gl/shared/pngdecoder.h?r1=482580&r2=528479&diff_format=h

Mime
View raw message