harmony-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tony Wu" <wuyue...@gmail.com>
Subject Re: [classlib][luni]Delete DatagramSocket.isMulticastSocket?
Date Wed, 04 Apr 2007 08:11:05 GMT
+1 to delete this unused method

On 4/4/07, Alexey Petrenko <alexey.a.petrenko@gmail.com> wrote:
> I think that there will be no harm in deleting unused method.
> We can restore it from the SVN if it will be needed in the future.
>
> So feel free to file a JIRA and suggest a patch.
>
> SY, Alexey
>
> 2007/4/4, LvJimmy´╝îJing <firepure@gmail.com>:
> > Hi All,
> >
> >     I happen to meet a package private method of DatagramSocket(and
> > its child class MulticastSocket), named isMulticastSocket. I search in
> > the luni package but find no line refers to this method. And a simple
> > search in native code shows no native code refers to this method by
> > reflection.
> >     I doubt we can still tell if a datagram socket is multi-cast
> > without this method, and what's more, the method currently seems no
> > use at all, and luni test passed without it.
> >     Do someone the use (or history) of the method? If no, I'd like
> > add a patch to delete it.
> >
> > --
> >
> > Best Regards!
> >
> > Jimmy, Jing Lv
> > China Software Development Lab, IBM
> >
>


-- 
Tony Wu
China Software Development Lab, IBM

Mime
View raw message