Return-Path: Delivered-To: apmail-harmony-dev-archive@www.apache.org Received: (qmail 45830 invoked from network); 6 Mar 2007 09:45:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 Mar 2007 09:45:37 -0000 Received: (qmail 53735 invoked by uid 500); 6 Mar 2007 09:45:44 -0000 Delivered-To: apmail-harmony-dev-archive@harmony.apache.org Received: (qmail 53710 invoked by uid 500); 6 Mar 2007 09:45:43 -0000 Mailing-List: contact dev-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list dev@harmony.apache.org Received: (qmail 53701 invoked by uid 99); 6 Mar 2007 09:45:43 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Mar 2007 01:45:43 -0800 X-ASF-Spam-Status: No, hits=1.3 required=10.0 tests=RCVD_NUMERIC_HELO,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: domain of gcjhd-harmony-dev@m.gmane.org designates 80.91.229.2 as permitted sender) Received: from [80.91.229.2] (HELO ciao.gmane.org) (80.91.229.2) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Mar 2007 01:45:34 -0800 Received: from root by ciao.gmane.org with local (Exim 4.43) id 1HOWEB-000270-9a for dev@harmony.apache.org; Tue, 06 Mar 2007 10:45:04 +0100 Received: from 195.161.50.68 ([195.161.50.68]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 06 Mar 2007 10:45:03 +0100 Received: from Salikh.Zakirov by 195.161.50.68 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 06 Mar 2007 10:45:03 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: dev@harmony.apache.org From: Salikh Zakirov Subject: Re: [drlvm][threading] comments on Harmony-3288 Date: Tue, 06 Mar 2007 12:42:16 +0300 Lines: 14 Message-ID: References: <4dd1f3f00703042117y5b58f8abk9260a56270e2267@mail.gmail.com> <4dd1f3f00703050804k5ca38d74pc960bad5bca43479@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 195.161.50.68 User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) In-Reply-To: <4dd1f3f00703050804k5ca38d74pc960bad5bca43479@mail.gmail.com> Sender: news X-Virus-Checked: Checked by ClamAV on apache.org Weldon Washburn wrote: > I would caution > that we > should be careful of the performance impact of replacing #ifdefs with > call/returns. My guess is that this will not slow down things. In any > case, we need to measure. I would say that we *decrease* the depths of call chain by 1 by eliminating APR function layer. We could probably go further and replace functions with macros, but there is an issue with callers expecting status constants TM_ERROR_TIMEOUT, TM_ERROR_EBUSY etc. Probably, we could define them using system constants. This deserves some further thinking.